fix: collect config error on unhashable project.dynamic entry - #332
Merged
Conversation
A non-string (unhashable) entry in project.dynamic, e.g. a nested list, made the PEP 808 dual-dynamic membership test raise a raw TypeError before the dedicated dynamic-list validation could report a clean config error. Skip non-string entries so they are surfaced through error_collector instead. Closes pypa#331 Assisted-by: ClaudeCode:claude-opus-4.8
Assisted-by: ClaudeCode:claude-opus-4.8
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly better error (was missing collection).
🤖 AI text below 🤖
A non-string (unhashable) entry in
project.dynamic— e.g. a nested list — made the PEP 808 dual-dynamic membership test (field in data["project"]) raise a rawTypeError: unhashable type: 'list'before the dedicatedproject.dynamiclist validation could report a clean config error. This happened even withall_errors=True, where a collected diagnostic is expected.Skipping non-string entries in that loop lets them be surfaced through the normal
error_collectorpath instead. Added a regression test.Closes #331