[HOLD] Use physical targets for scaled parameter objectives#1080
Draft
mickaelbegon wants to merge 1 commit into
Draft
[HOLD] Use physical targets for scaled parameter objectives#1080mickaelbegon wants to merge 1 commit into
mickaelbegon wants to merge 1 commit into
Conversation
Collaborator
|
@mickaelbegon I don't think it is a good idea to scale only for these specific objectives and not sclae for the others, since the behavior will be different. The problem is that we cannot know how to modify the target for other objectives that involve a scaled variable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #848
Summary
MINIMIZE_PARAMETERin physical units by applying each parameter scalingkey="all"/NonecasesTests
pytest tests/shard6/test_penalty.py::test_penalty_minimize_parameter_returns_physical_values tests/shard6/test_penalty.py::test_penalty_minimize_state tests/shard6/test_penalty.py::test_penalty_minimize_torque -q(15 passed)This change is