Skip to content

[HOLD] Use physical targets for scaled parameter objectives#1080

Draft
mickaelbegon wants to merge 1 commit into
pyomeca:masterfrom
mickaelbegon:codex/fix-848-scale-standard-targets
Draft

[HOLD] Use physical targets for scaled parameter objectives#1080
mickaelbegon wants to merge 1 commit into
pyomeca:masterfrom
mickaelbegon:codex/fix-848-scale-standard-targets

Conversation

@mickaelbegon

@mickaelbegon mickaelbegon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Closes #848

Summary

  • evaluate MINIMIZE_PARAMETER in physical units by applying each parameter scaling
  • support both a named parameter and the aggregate key="all"/None cases
  • document that standard state and control penalties already expose unscaled variables
  • add regression coverage for heterogeneous parameter scaling

Tests

  • pytest tests/shard6/test_penalty.py::test_penalty_minimize_parameter_returns_physical_values tests/shard6/test_penalty.py::test_penalty_minimize_state tests/shard6/test_penalty.py::test_penalty_minimize_torque -q (15 passed)

This change is Reviewable

@EveCharbie

Copy link
Copy Markdown
Collaborator

@mickaelbegon I don't think it is a good idea to scale only for these specific objectives and not sclae for the others, since the behavior will be different. The problem is that we cannot know how to modify the target for other objectives that involve a scaled variable.

@mickaelbegon mickaelbegon changed the title Use physical targets for scaled parameter objectives [HOLD] Use physical targets for scaled parameter objectives Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaling of targets

2 participants