Skip to content

[Wave RHO][4/4] Expose supported advanced Acados options - #1074

Draft
mickaelbegon wants to merge 1 commit into
pyomeca:masterfrom
mickaelbegon:codex/pr-acados-advanced-options
Draft

[Wave RHO][4/4] Expose supported advanced Acados options#1074
mickaelbegon wants to merge 1 commit into
pyomeca:masterfrom
mickaelbegon:codex/pr-acados-advanced-options

Conversation

@mickaelbegon

@mickaelbegon mickaelbegon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Note

Wave RHO 4/4 — Draft/WIP. Tracking issue: #1086.

This wave and its decomposition come from an analysis performed by OpenAI Codex. Maintainer review is required before these proposals are considered ready.

Wave RHO context

The overall goal is to upstream generic, application-independent foundations for reliable receding-horizon workflows with IPOPT and Acados: solver-input correctness, supported warm-start grid transfer, explicit window outcomes/diagnostics/hooks, and finally supported solver tuning.

Proposed review/merge order:

  1. [Wave RHO][1/4] Fix Acados control-bound scaling and ordering #1075 — Acados control-bound correctness
  2. [Wave RHO][2/4] Adapt solutions to new initial-guess grids #1073 — solution-to-initial-guess grid adaptation
  3. [Wave RHO][3/4] Preserve receding-horizon outcomes and expose Acados diagnostics #1072 — RHO outcomes, hooks, cyclic shifts, diagnostics, and iterate access
  4. [Wave RHO][4/4] Expose supported advanced Acados options #1074 — advanced Acados options

Role of this PR: optional solver-tuning layer after correctness and RHO semantics are established.

Interaction: Code-independent from the other PRs, but intentionally last because it tunes execution rather than defining correctness or orchestration.

All four PRs target master independently; this is an interaction/review order, not a stacked Git dependency.

What changed

  • expose supported Acados collocation and integrator controls
  • expose Newton tolerance and Jacobian reuse
  • expose QP condensation, iteration limits and tolerances
  • expose regularization, Levenberg-Marquardt and globalization
  • omit optional values until configured
  • make option enumeration work with deferred annotations

Why

These options exist in the bundled acados_template version but previously required the unsafe generic option API.

Validation

  • pytest -q tests/shard4/test_acados_advanced_options.py
  • 2 passed

Scaling/qpscaling and SQP_WITH_FEASIBLE_QP are intentionally not exposed because the bundled Acados version does not support them.


This change is Reviewable

@mickaelbegon mickaelbegon changed the title Expose supported advanced Acados options [HOLD] Expose supported advanced Acados options Jul 22, 2026
@mickaelbegon
mickaelbegon force-pushed the codex/pr-acados-advanced-options branch from e600960 to db42f07 Compare July 27, 2026 15:20
@mickaelbegon mickaelbegon changed the title [HOLD] Expose supported advanced Acados options [Wave RHO][4/4] Expose supported advanced Acados options Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.33735% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.94%. Comparing base (89c83a3) to head (db42f07).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
bioptim/interfaces/acados_options.py 84.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
+ Coverage   77.26%   77.94%   +0.68%     
==========================================
  Files         196      196              
  Lines       21506    21574      +68     
==========================================
+ Hits        16616    16816     +200     
+ Misses       4890     4758     -132     
Flag Coverage Δ
unittests 77.94% <84.33%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant