Skip to content

[HOLD] Track variational solver convergence - #1070

Draft
mickaelbegon wants to merge 1 commit into
pyomeca:masterfrom
mickaelbegon:codex/track-990-convergence
Draft

[HOLD] Track variational solver convergence#1070
mickaelbegon wants to merge 1 commit into
pyomeca:masterfrom
mickaelbegon:codex/track-990-convergence

Conversation

@mickaelbegon

@mickaelbegon mickaelbegon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a reusable solver-convergence assertion with an optional iteration ceiling
  • report solver status and iteration count in assertion failures
  • protect four variational-integrator variants against convergence and major iteration regressions

Rationale

Exact IPOPT iteration counts can vary across platforms and dependency versions. This first increment uses a deliberately broad ceiling of 100 iterations for problems that currently converge comfortably below it, detecting meaningful regressions without making CI unnecessarily brittle.

Validation

  • MPLCONFIGDIR=/private/tmp/bioptim-mpl-990 python -m pytest tests/shard4/test_variational_integrator_examples.py -vv (4 passed)
  • git diff --check

Progress toward #990; this does not close the repository-wide tracking issue.


This change is Reviewable

@mickaelbegon mickaelbegon changed the title Track variational solver convergence [HOLD] Track variational solver convergence Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant