[HOLD] Track variational solver convergence - #1070
Draft
mickaelbegon wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
Exact IPOPT iteration counts can vary across platforms and dependency versions. This first increment uses a deliberately broad ceiling of 100 iterations for problems that currently converge comfortably below it, detecting meaningful regressions without making CI unnecessarily brittle.
Validation
MPLCONFIGDIR=/private/tmp/bioptim-mpl-990 python -m pytest tests/shard4/test_variational_integrator_examples.py -vv(4 passed)git diff --checkProgress toward #990; this does not close the repository-wide tracking issue.
This change is