[WAVE 2][RTR] Validate parameter interpolation types - #1067
Conversation
89cb4c3 to
a0d1d86
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
+ Coverage 77.26% 77.86% +0.60%
==========================================
Files 196 196
Lines 21506 21507 +1
==========================================
+ Hits 16616 16747 +131
+ Misses 4890 4760 -130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Codex analysisThis PR is part of Wave 2 and is rebased onto current CI exposed one related NMPC path: the internal one-cycle Review isolation: the PR changes the parameter-validation path, the NMPC one-cycle initializer, and its focused test file; it has no source-file overlap with #1062 or #1065. Validation completed by Codex:
@EveCharbie @pariterre, all local and online checks are green. This PR is ready for review as an independent Wave 2 change. |
Summary
InterpolationType.CONSTANTfor parameter boundsRoot cause
Parameters have no shooting-node dimension, but their bounds and initial guesses were accepted with time-dependent interpolation types. In particular, omitting the interpolation for a
BoundsListsilently selectedCONSTANT_WITH_FIRST_AND_LAST_DIFFERENT, which is not meaningful for a parameter.Validation
MPLCONFIGDIR=/private/tmp/bioptim-mpl-863 python -m pytest tests/shard6/test_update_bounds_and_init.py::test_update_bounds_and_init_with_param -q(2 passed)git diff --checkCloses #863
This change is