[HOLD] Reject all-points control initial guesses - #1066
Draft
mickaelbegon wants to merge 2 commits into
Draft
Conversation
…ol-all-points-validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InterpolationType.ALL_POINTSfor control initial guessesRoot cause
NonLinearProgram.update_initvalidatedALL_POINTSfor states and algebraic states but omitted controls. Collocation sub-points exist for state decision variables, not control decision variables, so accepting this interpolation foru_initis ambiguous and can lead to inconsistent dimensions.Validation
MPLCONFIGDIR=/private/tmp/bioptim-mpl-970 python -m pytest tests/shard2/test_global_getting_started.py -k 'test_initial_guesses and ALL_POINTS' -q(4 passed)git diff --checkCloses #970
This change is