fix(desktop): add planModeEnabled to the client settings fixture - #60
Merged
Merged
Conversation
Adding `planModeEnabled` to `ClientSettingsSchema` in #59 broke `DesktopClientSettings.test.ts`, whose fixture is an exhaustive `ClientSettings` literal rather than a spread of the defaults, so a new key fails both typecheck and the round-trip assertion. Upstream's #5551 updated this same file in the same commit. I ported that change instead of cherry-picking it and did not carry the one-line fixture update across, then verified only web and contracts — the two packages I had edited — while the fixture lives in desktop. A contracts change fans out to every consumer, so the scope to verify is every consumer. Confirmed clean across all seven: web, desktop, server, shared, contracts, client-runtime, and mobile. This is the only exhaustive settings fixture in the repo; the `modelSelection.test.ts` ones spread the defaults.
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pylonis red. AddingplanModeEnabledtoClientSettingsSchemain #59 brokeDesktopClientSettings.test.ts, failing both the Test and Check jobs on509d497d8.That fixture is an exhaustive
ClientSettingsliteral rather than a spread of the defaults, so any new key breaks it:How I missed it
Upstream's
#5551updated this same file in the same commit — one line. I ported that change rather than cherry-picking it (deliberately, since the commit is 338 back and its other hunks are stale) and did not carry the fixture update across.Then I verified only web and contracts — the two packages I had edited — while the fixture lives in desktop. A contracts change fans out to every consumer, so the scope to verify is every consumer, not the files I happened to touch.
Verification
DesktopClientSettings.test.ts: 7 tests, passing.modelSelection.test.tsfixtures spreadDEFAULT_UNIFIED_SETTINGS, which is why they were unaffected.Model: Claude Opus 5 in Pylon.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.