Skip to content

chore(upstream): adopt the 2026-08-18 T3 Code batch - #46

Merged
rynfar merged 16 commits into
pylonfrom
upstream/2026-08-18-batch
Aug 18, 2026
Merged

chore(upstream): adopt the 2026-08-18 T3 Code batch#46
rynfar merged 16 commits into
pylonfrom
upstream/2026-08-18-batch

Conversation

@rynfar

@rynfar rynfar commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Adopts all eleven upstream commits from bab4b6f02..82b8a9380 (2026-08-17 – 2026-08-18). None were patch-equivalent to Pylon, and the deferred register was empty going in and stays empty.

What's here

#6466 protects source-control API budgets — the most valuable change in the batch, and it applied without a single conflict. One GitHub pull request detail load was spending 104 GraphQL points: it asked for 100 replies per review thread, followed every reply cursor, and refreshed every minute. This adds an Effect cooldown service keyed by provider plus host, native rate-limit detection for GitHub, GitLab, Bitbucket, and Azure DevOps, a GraphQL cost budget reserving the last 10% for interactive actions, and 10-reply pagination behind Load more comments. Upstream measured 104 → 14 points on a 44-thread PR. Three behavior changes ride along and were accepted deliberately: long threads paginate instead of loading eagerly, live refresh slows 1 min → 5 min, and the idle cutoff moves 5 min → 6 min.

#7172 stops threads lying about being busy — a late task.progress with no status was re-adding an already-idle task to the live set, leaving the sidebar on Working with zero live agents.

#7082 + #7083 add Settings → Integrations — default preview viewport, zoom, appearance, and floating-preview auto-show, plus an Agent browser access toggle that withholds the MCP credential in prepareMcpSession. That's the only place a credential is minted, so one branch covers all five providers.

#7209 bans native title tooltips behind a new error-level oxlint rule and migrates 33 sites. #7077 makes review verdicts a first-class timeline row. #7219 removes a silent .slice(0, 8) that was hiding up to 82 rows of the usage breakdown. Plus #7321, #7276, #7296, and #7364.

Pylon-first resolutions

Applying in upstream chronological order mattered: #7083's conflicts and #7077's both disappear once their predecessors land first.

  • ServerUpdateAction.tsx — kept Pylon's <DotMatrix state="error"> where upstream has a plain destructive dot; took the tooltip wrapper.
  • Sidebar.tsx — kept Pylon's themed text-warning token over upstream's text-amber-700 dark:text-amber-300 on the Woke pill.
  • BrowserDeviceToolbar.tsx — upstream's cn() guards are constant inside each ternary branch, so Pylon's plainer classes say the same thing; kept ours.
  • CodexSessionRuntime.test.ts — took upstream's new codexDefaultModeDeveloperInstructions(hasBrowserTools) function, kept Pylon's /Pylon/ assertion.
  • SettingsPanels.logic.test.ts — both sides append describe blocks at the tail; both kept.

Two fixes beyond conflict resolution: #7083 asserted the absence of "T3 Code collaborative browser", a heading Pylon renamed long ago, so it passed vacuously — repointed at Pylon's actual heading. And the new Integrations panel's module comment named T3 Code.

Because #7209's rule lands at error, upstream's migration isn't sufficient on its own — running the rule found four more sites in ProviderUsageMatrix.tsx, a Pylon-only surface. Three became styled tooltips; the row-label cell never truncates, so its title only repeated visible text and was dropped.

Verification

Typecheck clean across contracts, shared, client-runtime, web, desktop, server, and mobile. Targeted tests: server 35 files / 707 tests, web 32 / 245, desktop 1 / 7, oxlint plugin 1 / 11 — all passing. vp lint reports 0 errors over the touched trees; vp fmt --check clean. routeTree.gen.ts is generated, so its imports were checked against the route files on disk rather than trusted.

Not verified in a real client. The surfaces that would most repay a pass are Settings → Integrations, the pull request detail, and the two mobile changes.

Built with Claude Opus 5 (1M context) in Claude Code.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

UtkarshUsername and others added 15 commits August 18, 2026 11:11
…#7209)

(cherry picked from commit fee10def1afb63cecd9a626aeba2bb063828cf22)
The no-native-title-tooltip rule adopted with #7209 lands at error, and
ProviderUsageMatrix is a Pylon-only surface upstream's migration could not
reach. Three sites become styled tooltips; the row-label cell never
truncates, so its title only repeated what was already on screen.
(cherry picked from commit ba46f922a271942d42faf305ff833af89cb5c3a1)
…#7082)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 949feb61e4bfd96669ba0e8cf3dca7c6d7f885b3)
(cherry picked from commit 13458e65106005ca183c02b5c84f9355b67feadb)
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit cd096b9ad5a4156ffeab85de617cbb219057007f)
The #7083 test asserted the absence of "T3 Code collaborative browser",
a heading Pylon renamed long ago, so it passed without proving anything.
The new Integrations panel's module comment named T3 Code too.
…7077)

(cherry picked from commit c7e6d711d3f2982e54854258987509e8f69b31cd)
(cherry picked from commit 33a8b07dd3b46e5cab8661a323faec20823ed9cb)
(cherry picked from commit a4cc1367b03ee0c1dc2b50fceac81ef5e63212e2)
(cherry picked from commit 3723722f740dd5ee95b021ca6e2291400074be3b)
(cherry picked from commit cebac353defde6211c9e8c3d8ecd140c92042930)
…s (#7172)

(cherry picked from commit 82b8a9380298509d68170961d9717be62836e490)
#7083 imported EnvironmentId into ProviderService.test.ts without using
it, which lands as a lint warning here.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 18, 2026
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 68823f1.

This comment will update automatically after the next completed run.

@rynfar

rynfar commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

Review pass

An xhigh review plus a browser pass against the branch. Both confirmed the integration; neither is a blocker.

Verified live (seeded database, real GitHub data): the new Settings → Integrations page lists in the nav, with #7083's Agent browser access enabled and #7082's four client-local defaults dimmed as one block — the intended split. #7209 checked at runtime rather than by lint alone: zero native title attributes remain on intrinsic elements in the rendered DOM. #7077's Reviewers row renders above the conversation.

Not reachable: #7219's usage breakdown never finished loading against the seeded database, and no pull request in reach carried an approval or an 11-comment thread. Mobile was not exercised.

All five Pylon-first resolutions confirmed clean, including the BrowserDeviceToolbar equivalence claim — upstream's cn(aspectRatio !== null && …) guards really are constant inside each ternary branch.

Two inherited upstream defects found, deferred to a follow-up as DEF-3 and DEF-4 so this PR stays a faithful adoption. Both exist in upstream main:

  1. #6466 narrowed truncated to "a thread has an 11th reply" while three readers still treat it as "the conversation is short of the host" — #7077's approval badge is suppressed, the handoff prompt gains a spurious notice, and the agent prompt receives only a thread's oldest 10 comments.
  2. githubGraphQlBudget compares GitHub's true remaining against a locally-reserved figure, so honest responses are always discarded and the cost estimate only ratchets upward. Fails safe and resets hourly.

One finding dismissed: the #7172 liveness guard matches the module's documented "orphaned background work is not live" intent.

Details in .agents/upstream-review.md (68823f1).

@rynfar
rynfar merged commit 6cc2308 into pylon Aug 18, 2026
11 checks passed
@rynfar
rynfar deleted the upstream/2026-08-18-batch branch August 18, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants