chore(upstream): adopt the 2026-08-16 T3 Code batch - #44
Merged
Conversation
Co-authored-by: maria <maria@kuuro.net> (cherry picked from commit e58cbb9e75e97448f88d0fe2eccc8a45cd980394)
(cherry picked from commit 2f486ab80c748b4d8e3d3b17e49b5a327cb93335)
…e (#7132) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit d484735c64ed98a0737b594818996660f72c1616)
(cherry picked from commit 27732293373fbb081a966b437ae022afe77db16b)
(cherry picked from commit 3583cd27dccda1b35fe80d9411a95a7217cc8176)
(cherry picked from commit d23b181da0cee78bcc327b6673218b776a3cb023)
…nk (#7171) (cherry picked from commit 4cb676cc1612e6220246cd5f8abdd2bc284e1a97)
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com> (cherry picked from commit 4c1d99d7f3e722c5e88c0dda6a96f9de8f296115)
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com> (cherry picked from commit 89c52a33179bc0932b901f637ad9acb615423436)
Thread transfer impact
This comment will update automatically after the next completed run. |
Two regressions arrived with the #7107 adoption. Inspect picks that folded into the canvas or accent family skipped the role-filter reset, so in Advanced mode with a filter typed the field the reveal scrolls to was not in the DOM. Advanced hex fields canonicalized to OKLCH on every keystroke, and '#ff0' is a valid color, so typing '#ff0000' snapped to yellow on its way to red. The family is still derived from the typed value; only the edited field keeps what was typed, and save canonicalizes as before.
Adds the xhigh review outcome, the two Pylon-first fixes with their browser A/B evidence, the iOS Simulator theme pass, and the finding that Pylon fixtures must come from ~/.pylon-code rather than ~/.t3.
The entry blamed vite's define block. Instrumenting the config showed test mode is detected and scoping define out left the tests failing unchanged, so the real mechanism is the process.env assignment at config module scope combined with Vite's VITE_ exposure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
t3code-upstream/mainmoved ten commits past Pylon's review cursor. Nine are worth having and one points Windows users at a worse experience, so this branch adopts nine and skips one.What landed
#6663tightens the themed-palette selector tohtml[data-theme-id]:not([data-theme-id=""]), closing the watch item left open by the 2026-08-15 batch.#7107reworks the Advanced theme editor from ~60 raw color roles into named families, deriving paired foregrounds only for the family you touch so imported palettes survive editing.#6619gives mobile the built-in theme library and System/Light/Dark selection, and moves the canonical palettes and preview generation intopackages/sharedso web and mobile cannot drift.#7132stops a keyboard-highlighted command menu item from resting under the scroll-fade mask.#6267and#7157remove ~960 lines of duplicate and stale tests plus four test-only exports.#7171replaces theCLAUDE.mdsymlink with an@AGENTS.mdpointer file, which Windows checkouts cannot corrupt.#6392truncates long commit-dialog paths from the start so the filename stays visible.#6635lifts two Android thread-settings screens clear of the status bar.Skipped:
#7208, which drops the Windows-only silent-install warning from the update confirmation. Upstream's reason is that install times have improved — a claim about T3's pipeline, not Pylon's Windows builds. The warning describes real behavior (the app closes for minutes with no installer window), and without it Pylon reads as hung.Pylon-first resolutions
ProviderIcon.tsx— kept Pylon'sCircleandproviderIconKindprovider marks while taking upstream'suseAppearancePreferences.themePalette.ts— took upstream's file wholesale as the T3 Chat palettes move topackages/shared, then restored the three Pylon comment rebrands that survive the deletion.ProviderRegistry.test.ts— kept Pylon's rate-limit projection test, which sits immediately before the test upstream deletes.#6619follows the F10 precedent: the mobile default theme id stayst3-codeso saved preferences keep resolving, while its visible label, the newdocs/user/mobile-appearance.md, and two doc comments became Pylon's.pnpm-lock.yamlis untouched —packages/shared/package.jsongains subpath exports only.Verification
Typecheck clean across web, mobile, shared,
t3, and desktop.vp fmt --checkclean over 96 files. Tests: mobile 790/790, shared 10, serverProviderRegistry52, scriptsmobile-showcase22, web 2,738/2,741.The three web failures are in
cloud/connectCliAuth.test.ts, which this branch does not touch, which fails in isolation, and which fails identically on a cleanorigin/pyloncheckout.vite.config.tsassigns the repo's mappedVITE_keys intoprocess.envat module scope and Vite exposes them onimport.meta.env, so the test reads a local.envthat suppliesT3CODE_CLERK_CLI_OAUTH_CLIENT_ID. CI has no such.env. Fixed separately in #45.(An earlier revision of this description blamed vite's
define:block. That was wrong — scopingdefineout of test mode left the tests failing unchanged.)vp lintcould not run in this environment at all, on this branch or on untouched files — oxlint fails to loadoxlint-plugin-t3code/index.tswithERR_UNKNOWN_FILE_EXTENSIONunder both Node 22 and Node 24. Lint coverage here is unproven locally; CI owns it.Not verified in a real client.
#6619spans native headers, sheets, terminal, and code review, so a simulator pass is the obvious next step.Model and harness: Claude Opus 5 via the
review-t3-upstreamskill in Pylon.Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.