Skip to content

fix(mobile): remove stray composer text - #32

Merged
rynfar merged 1 commit into
pylonfrom
fix/mobile-thread-runtime-errors
Aug 16, 2026
Merged

fix(mobile): remove stray composer text#32
rynfar merged 1 commit into
pylonfrom
fix/mobile-thread-runtime-errors

Conversation

@rynfar

@rynfar rynfar commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Problem

ThreadComposer emitted an explicit whitespace text child between the attachment modal and image viewer. React Native requires raw strings to be inside <Text>, so opening an ordinary thread could produce Text strings must be rendered within a <Text> component. even though the composer otherwise rendered correctly.

Fix

Remove the stray JSX whitespace child. The null-submission crash originally included in this PR was independently merged in #38, so this branch was rebased and reduced to its one remaining unique fix instead of duplicating that logic.

Verification

  • targeted lint for ThreadComposer.tsx
  • vp run -F @t3tools/mobile typecheck
  • git diff --check
  • integrated iOS Simulator reproduction from the original review rendered the seeded ordinary thread without the raw-text-child warning

Model: GPT-5.6; Harness: Prime Agent.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Aug 14, 2026
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for cc34dc5.

This comment will update automatically after the next completed run.

@rynfar
rynfar force-pushed the fix/mobile-thread-runtime-errors branch from 98e9c9c to cc34dc5 Compare August 16, 2026 17:14
@rynfar rynfar changed the title fix(mobile): keep idle threads error-free fix(mobile): remove stray composer text Aug 16, 2026
@github-actions github-actions Bot added size:XS and removed size:M labels Aug 16, 2026
@rynfar
rynfar merged commit 0363be0 into pylon Aug 16, 2026
11 checks passed
@rynfar
rynfar deleted the fix/mobile-thread-runtime-errors branch August 16, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant