Skip to content

fix(server): keep Windows Prime daemon fallback fail-closed - #29

Merged
rynfar merged 1 commit into
pylonfrom
fix/prime-windows-daemon-fallback
Aug 14, 2026
Merged

fix(server): keep Windows Prime daemon fallback fail-closed#29
rynfar merged 1 commit into
pylonfrom
fix/prime-windows-daemon-fallback

Conversation

@rynfar

@rynfar rynfar commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Problem

Windows native daemon mode is intentionally disabled because Prime Agent 0.7.2 cannot authenticate named-pipe peers. The manager nevertheless imported the executable-adjacent Prime package before applying that platform guard, so npm shim/package-layout failures could accidentally determine the fallback instead of the security policy.

Solution

Apply the Windows transport-security guard immediately after deriving the private pipe identity, before loading any Prime package code or attempting process startup. The focused regression omits the fake bridge and uses the nonexistent fixture executable, proving the fail-closed outcome does not depend on package discovery and still spawns nothing.

Verification

  • vp test run src/provider/prime/PrimeAgentDaemonManager.test.ts src/provider/prime/PrimeAgentBackendSelection.test.ts src/provider/Drivers/PrimeAgentDriver.test.ts — 23 passed
  • server typecheck passed with existing Effect suggestions only
  • targeted lint — 0 warnings, 0 errors
  • git diff --check

Implemented by OpenAI Codex GPT-5.6 Sol using the Prime Agent harness.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Aug 14, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 312c200.

This comment will update automatically after the next completed run.

@rynfar
rynfar merged commit 997a109 into pylon Aug 14, 2026
11 checks passed
@rynfar
rynfar deleted the fix/prime-windows-daemon-fallback branch August 14, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant