feat(web): make individual settings searchable, dedupe composer skills - #242
Merged
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
rynfar
force-pushed
the
upstream/2026-09-02-settings-search
branch
from
September 2, 2026 17:58
191ce6b to
ed613f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three upstream adoptions around settings search and the composer skill menu.
#8881make WSL settings searchable — applied clean#8831search individual settings by detail#8043dedupe skills in composer menusSettings search now matches on a setting's own title and terms rather than only
its panel, and the panel scrolls to and opens the matched control — including
expanding a collapsed Advanced section.
Carve-outs
#8831routes several titles through asearchableSetting(...)registry lookup.Two of those registry entries are product copy that arrived branded: the
t3-connectentry's title and the "Publish agent activity" description. Thecompatibility id
t3-connectis kept as-is; the title and description now sayPylon Connect.
#8831's hunk for the composer-capacity row would have replaced Pylon's"Subscription capacity in the composer"
SettingsRowoutright — that row isPylon's and upstream has no equivalent. Kept, with upstream's new
idpropapplied to the row that actually follows it.
Upstream added
searchTermsto thelegacy-plan-modeentry, but Pylon's catalogorders that entry differently, so the hunk landed as a second copy rather than an
edit — 55 entries, 54 unique ids.
settingsSearch.test.ts's uniqueness assertioncaught it. The duplicate is removed and the terms folded into Pylon's entry.
#8043's mobile hunk is written against an inline command-item builder that Pylonhas since extracted into
buildComposerCommandItems. Taking it would havereverted that refactor. Pylon's structure is kept and the actual fix applied where
the code now lives: the
trigger.kind === "skill"path was still filteringenabled skills without deduping, so a skill defined in two directories showed a
duplicate row. It now calls
dedupeProviderSkillsByName.ProviderSettingsPanel.environment.test.tsxgained upstream'sfindAdvancedPaneland
flushEffectshelpers alongside Pylon'sisAdvancedTrigger. Upstream's findermatches on
className="mt-1"plus a booleanopenprop, which Pylon's<Collapsible>satisfies, so both work against Pylon's markup.Verification
@t3tools/web,@t3tools/mobile, and@t3tools/client-runtimetypecheck clean.Lint clean. 144 settings tests, 171 mobile thread-feature tests, 13
client-runtime skill tests passing. No
T3 CodeorT3 Connectin any added line.Unrelated and left alone: a stale "T3 Connect" mention in a
Sidebar.tsxcodecomment predates this branch.
Model: Claude Opus 5 in Claude Code.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.