fix(web): stop pull request metadata overlapping and mark links external - #213
Conversation
(cherry picked from commit cefec32d6fc5d14f03e110ebdde534bdbcc9b62b)
(cherry picked from commit e9c4775e8738381140af4e5248507b15fc1cd491)
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Review follow-up on the #8856 port. Marking the inline link external left the same action in the overflow menu on ArrowUpRightIcon, so one header offered two marks for one behaviour. Both now use ExternalLinkIcon.
|
Adversarial review found no correctness defects. It confirmed both commits are byte-identical cherry-picks with Pylon pre-images matching upstream, and checked the subtle bits: the meta-line separator keys stably as Three presentation-level findings. One fixed, two recorded. Fixed: the header used two glyph vocabularies for one action — the inline link got Recorded, not fixed — these are upstream's responsive design calls and want the browser pass the PR body already asks for:
Re-verified: |
Two small defects on the pull requests surface. A long branch or title pushed the
row's metadata into the adjacent element instead of truncating, so the row read as
overlapping text at narrow widths. Separately, links out to the forge opened
without external-link treatment, giving no signal that they leave the app.
Row metadata now truncates within its own track, and forge links are marked
external.
Adopted from upstream
pingdotgg/t3code#8790(cefec32d6) and#8856(
e9c4775e8), both cherry-picked clean. Grouped because both are pull-request-rowpresentation.
Verified:
vp test run --dir apps/web apps/web/src/components/pullRequest,vp run -F @t3tools/web typecheck(exit 0, no errors).Visual change, not exercised in a browser — happy to do a real-client pass on request.
Reviewed and integrated with Claude Opus 5 in Claude Code.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.