fix(clients): ignore stale compaction after session stops - #129
Merged
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A completed Prime Agent thread could become permanently unsendable after its session stopped. If the provider missed a compaction terminal event, the web composer kept treating the last persisted
compactingactivity as live even though no active session remained, so Send was disabled without a surfaced error.Fix
Require an active, compaction-capable session scope before compaction state can block composer submission. The shared guard is used by web and mobile, and the regression test covers a stopped session with stale
compactingactivity.Verification
vp test run packages/client-runtime/src/state/contextCompaction.test.ts(7/7)vp run -F @t3tools/client-runtime typecheckvp run -F @t3tools/web typecheckvp run -F @t3tools/mobile typecheckvp linton all four changed filesvp fmt --checkon all four changed filesgit diff --checkIntegrated browser evidence is pending explicit permission for browser use.
Implemented with GPT-5.6 Sol using the Prime Agent harness.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.