[MRG] Document that the acceptor's transfer syntax order decides negotiation - #1089
Open
CedricConday wants to merge 1 commit into
Open
[MRG] Document that the acceptor's transfer syntax order decides negotiation#1089CedricConday wants to merge 1 commit into
CedricConday wants to merge 1 commit into
Conversation
The rule is stated in the "Implementation Note" on the presentation context negotiation page, but not at either API surface where an SCP is configured, so it reads as a bug when a requestor's preferred transfer syntax loses to the acceptor's. Note it on AE.add_supported_context and negotiate_as_acceptor, and spell out the consequence and the remedy in the negotiation page. Documentation only, no behaviour change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1085, which read the acceptor-preference behaviour as a bug.
The rule is already stated in the "Implementation Note" on the presentation context negotiation page, but it isn't mentioned at either API surface where an SCP is actually configured, so a requestor's preferred transfer syntax losing to the acceptor's reads as a defect rather than as intended behaviour.
AE.add_supported_context: note thattransfer_syntaxis given in order of preference, that the first entry the requestor also proposed is the one accepted, and that the requestor's ordering is not taken into account.negotiate_as_acceptor: state the same selection rule, citing PS3.7 Section D.3.2, which requires only that exactly one of the proposed transfer syntaxes be accepted and leaves the choice to the acceptor.Documentation only, no behaviour change. The example was run against 3.0.4 and accepts JPEG-LS Lossless as written.