Add native Go pricing package - #658
Conversation
|
Macroscope skipped reviewing this pull request. Per-review cost limit exceeded (workspace setting). This review would cost an estimated $27.33, which exceeds your per-review limit of $10.00. The top 3 files driving up this estimate:
Tip To get this pull request reviewed, you can:
|
There was a problem hiding this comment.
All reported issues were addressed across 27 files
Not reviewed (too large): packages/go/internal/data/prices.json (~1 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 17 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
@macroscope-app review please |
|
Manual reviews triggered for commit All prior checks · these links stay valid even if you push more commits. |
|
Review started; results will be posted as checks. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR introduces a substantial production-facing Go pricing and usage-extraction module, including new runtime logic, embedded data, and billing-related calculations, rather than a bounded maintenance change. It also modifies Macroscope configuration and has unresolved medium/high findings concerning pricing accuracy, overflow handling, provider matching, and download behavior. Not approved because:
Enable approvability here. Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Adds a nested Go module at
packages/gowith embedded generated pricing data, model/provider matching, usage extraction, tiered and conditional pricing, and forward-compatible warnings. The shared 1,577-response dataset verifies parity with the Python and JavaScript implementations, and CI now formats, lints, race-tests, and covers the Go package.Closes #407.
AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.