Skip to content

Use provider tier boundary conventions - #614

Open
Kludex wants to merge 6 commits into
mainfrom
codex/tier-boundary-inclusivity
Open

Use provider tier boundary conventions#614
Kludex wants to merge 6 commits into
mainfrom
codex/tier-boundary-inclusivity

Conversation

@Kludex

@Kludex Kludex commented Aug 26, 2026

Copy link
Copy Markdown
Member

Apply inclusive tier boundaries for OpenAI and xAI while preserving exclusive boundaries for other providers. Keep the frozen v2 schema unchanged and test exact-threshold behavior in both engines.

Closes #587

AI Disclaimer

This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 18 files

Re-trigger cubic

@Kludex Kludex changed the title Support inclusive price tier boundaries Use provider tier boundary conventions Aug 26, 2026
@Kludex

Kludex commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

The initial per-tier field changed the frozen v2 schema, so I replaced it with the provider convention proposed in the issue. OpenAI and xAI now use inclusive thresholds in both runtimes, other providers remain exclusive, and the v2 schemas are unchanged.

Comment thread packages/js/src/api.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 19 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread packages/js/src/api.ts Outdated
Comment thread packages/python/genai_prices/types.py Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread packages/python/genai_prices/data_snapshot.py Outdated
Comment thread packages/python/genai_prices/types.py Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread packages/python/genai_prices/types.py Outdated
@Kludex

Kludex commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

This needs human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tier boundary is exclusive for every provider, but xAI and OpenAI document it as inclusive

1 participant