This repository was archived by the owner on Jun 7, 2026. It is now read-only.
Fix bytes rendered wrong#106
Open
ischaojie wants to merge 2 commits into
Open
Conversation
Member
|
I don't think this fixes it, but I might be wrong. We need to fix tests and check all cases are covered. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 83.66% 83.81% +0.15%
==========================================
Files 10 10
Lines 661 661
==========================================
+ Hits 553 554 +1
+ Misses 108 107 -1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #31
I'm not quite sure what the reason is for the format being specified as
binaryinJsonSchemaFile, but comparing the implementation in react-jsonschema-form hereformat=data-url, a detail not specified in thejson-schemastandard, and it looks like we could use a similar implementation here?