Repository navigation
Reject BLAKE2b digest lengths that abort the process - #971
Open
shaneraphel wants to merge 1 commit into
Open
shaneraphel wants to merge 1 commit into
shaneraphel wants to merge 1 commit into
Conversation
libsodium treats an output length of 0 or above 64 as misuse. A directly constructed state reached that call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #967 and #964.
crypto_generichash_blake2b_finalcallssodium_misusewhen the output length is 0 or greater than 64, which aborts the interpreter.generichash_blake2b_initand the one-shot helper only rejected lengths above 64, so a length of 0 reached libsodium. ABlake2Stateconstructed directly skipped that check, so a length of 65 did too.Both paths now require a length from 1 through
crypto_generichash_BYTES_MAXbefore the C call. Length 1 still returns a one-byte digest. Lengths 0, -1, and 65 raiseValueError.tests/test_generichash.py: 2137 passed, 4 skipped. The rest of the suite was not run.