fix: fix type hint of Timeline.to_annotation - #98
Closed
lukasstorck wants to merge 1 commit into
Closed
Conversation
Author
|
I guess what happened was, when the type hints were first added in the new line 921, it was first though of as a Generator with |
Member
|
Closing in favor of #96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
generatoris set toNone, the function would raise an Exception in line 1067 whennext(generator)is call onNone. So I guess generator should never beNone.At first I only wanted to correct the duplicate
Nonein the type hint, so I would update the type hint, ifNoneis handled in any other way.