[codex] Add video capture audio selector#191
Open
huntharo wants to merge 1 commit into
Open
Conversation
huntharo
marked this pull request as ready for review
June 1, 2026 20:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds audio controls to the video selector so users can choose whether a recording includes audio before recording starts.
What Changed
System audioandMicrophonetoggles to the area selector.settings.recordingand persisted the latest choice.Verification
pnpm --filter @pwrsnap/desktop typecheckpnpm exec vitest run --config vitest.workspace.ts --project desktop-renderer apps/desktop/src/renderer/src/features/region/__tests__/RegionSelectorAudio.test.tsx apps/desktop/src/renderer/src/features/region/__tests__/region-math.test.tsNote
A broad workspace Vitest invocation was attempted first, but this local checkout's Electron package reports
Electron failed to install correctly, which breaks desktop-main suites before this change can be evaluated there.