Enable simple Btrfs quotas - #1145
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5e924c115
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mount "$loop_device" /data/homes | ||
| fi | ||
| btrfs quota enable /data/homes | ||
| btrfs quota enable --simple /data/homes |
There was a problem hiding this comment.
In the default Ubuntu 24.04 image (Dockerfile:41,53), btrfs-progs resolves to 6.6.3, while the upstream v6.7 changelog introduces “simple quota accounting (squota) support.” On a fresh deployment this command therefore rejects --simple; because dojo-init does not exit on the error, startup continues with quotas disabled, and the checked btrfs qgroup limit call in homefs/btrfs_volume.py:68 then prevents home activation instead of enforcing the documented 1 GiB limit. Upgrade the packaged utility or avoid this option until a supporting version is installed.
AGENTS.md reference: AGENTS.md:L121-L123
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 participant
Summary
Testing
sh -n dojo/dojo-initgit diff --check