adding --quite flag - #9
Open
kalebris wants to merge 11 commits into
Open
Conversation
the .Add() function incremeants the counter with the value while we need to be able to set the metric to the actual value
using ticker, also dealt with concurency when scraping and fetching happens at the same time to avoid returning the same value twice messing up counters
Contributor
Author
|
this became quite a monstrous pull request, due to incremental changes in our use-case. Not sure if this could still be merged, or should a new single commit pull request should be made for this. |
adding graphs name to error message of unexpected EOF so it's easier to identify misbehaving plugins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is to make loggging a bit more verbose, no reason to store the metrics in the logs on top of prometheus.