Skip to content

feat: FileFormat for VORTEX - #2

Draft
a10y wants to merge 640 commits into
pvary:file_Format_api_without_basefrom
spiraldb:main
Draft

feat: FileFormat for VORTEX#2
a10y wants to merge 640 commits into
pvary:file_Format_api_without_basefrom
spiraldb:main

Conversation

@a10y

@a10y a10y commented Mar 31, 2025

Copy link
Copy Markdown

I've consolidated the changes from #1, rebased onto the latest version of the FileFormat branch.

I have not resolved all of the comments from the old PR

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we have a stable writer implementation we should remove this and instead generate the file at test time

@pvary
pvary force-pushed the file_Format_api_without_base branch from 43e15f8 to d674db0 Compare April 11, 2025 13:18
@pvary
pvary force-pushed the file_Format_api_without_base branch 2 times, most recently from b5bad2c to 7a5f3a0 Compare May 6, 2025 12:54
@pvary
pvary force-pushed the file_Format_api_without_base branch 4 times, most recently from c6929b1 to 05309bc Compare May 26, 2025 15:15
@pvary
pvary force-pushed the file_Format_api_without_base branch from 820cd3e to 0c35110 Compare June 27, 2025 10:35
@pvary
pvary force-pushed the file_Format_api_without_base branch 2 times, most recently from 16265b6 to a04dec0 Compare July 22, 2025 13:25
@pvary
pvary force-pushed the file_Format_api_without_base branch 3 times, most recently from f828c3c to eb205c1 Compare August 15, 2025 21:50
@pvary
pvary force-pushed the file_Format_api_without_base branch 2 times, most recently from a7ce1cb to 40f91b4 Compare August 25, 2025 21:09
@pvary
pvary force-pushed the file_Format_api_without_base branch from df3d7c4 to 54ff177 Compare October 8, 2025 08:54
@pvary
pvary force-pushed the file_Format_api_without_base branch 7 times, most recently from d4f00af to e34f7ec Compare November 5, 2025 17:54
dependabot Bot and others added 30 commits May 24, 2026 10:29
…16555)

Bumps software.amazon.awssdk:bom from 2.44.4 to 2.44.7.

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:bom
  dependency-version: 2.44.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.4 to 4.35.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@68bde55...9e0d7b8)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.35.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [com.diffplug.spotless:spotless-plugin-gradle](https://github.com/diffplug/spotless) from 8.4.0 to 8.5.1.
- [Release notes](https://github.com/diffplug/spotless/releases)
- [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md)
- [Commits](diffplug/spotless@gradle/8.4.0...gradle/8.5.1)

---
updated-dependencies:
- dependency-name: com.diffplug.spotless:spotless-plugin-gradle
  dependency-version: 8.5.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `slf4j` from 2.0.17 to 2.0.18.

Updates `org.slf4j:slf4j-api` from 2.0.17 to 2.0.18

Updates `org.slf4j:slf4j-simple` from 2.0.17 to 2.0.18

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-version: 2.0.18
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.slf4j:slf4j-simple
  dependency-version: 2.0.18
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [zizmorcore/zizmor-action](https://github.com/zizmorcore/zizmor-action) from 0.5.3 to 0.5.6.
- [Release notes](https://github.com/zizmorcore/zizmor-action/releases)
- [Commits](zizmorcore/zizmor-action@b1d7e1f...5f14fd0)

---
updated-dependencies:
- dependency-name: zizmorcore/zizmor-action
  dependency-version: 0.5.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pache#16551)

Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.81.0 to 26.83.0.
- [Release notes](https://github.com/googleapis/java-cloud-bom/releases)
- [Commits](googleapis/java-cloud-bom@v26.81.0...v26.83.0)

---
updated-dependencies:
- dependency-name: com.google.cloud:libraries-bom
  dependency-version: 26.83.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add generic end-to-tend tests for Vortex
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Support case inensitive table scans, and enable TestLocalScan for Vortex
…mn (#31)

Support row-idx pushdown into Vortex scans matching the metadata column
Add support for position deletes in Vortex

Pushes position deletes into the Vortex scan so deleted rows are excluded natively instead of being read and filtered out afterwards.

DeleteFilter exposes the deleted positions for pushdown (skipped when the _is_deleted column is projected, since those rows must be marked rather than removed). GenericReader forwards them only when the reader advertises support via the new ReadBuilder.supportsPositionDeletes(), so Parquet/ORC/Avro keep applying deletes post-scan. VortexIterable serializes the positions as a portable 64-bit Roaring bitmap and applies EXCLUDE_ROARING row selection.

Also adds a Vortex position-delete writer (PositionDeleteVortexWriter, VortexFormatModel.forPositionDeletes) for writing path/pos delete files, plus TestVortexPositionDeletes.
Signed-off-by: Robert Kruszewski <github@robertk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.