test: assert the outbound success path records the OP-Stack L1 fee (F-2026-18145) - #328
Closed
Aman035 wants to merge 2 commits into
Closed
test: assert the outbound success path records the OP-Stack L1 fee (F-2026-18145)#328Aman035 wants to merge 2 commits into
Aman035 wants to merge 2 commits into
Conversation
Member
Author
|
Closing: no code changes going out for this finding. The fix (#304) is merged; these were coverage-only additions. Branch F-2026-18145-tests is retained if we want them later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #304 (F-2026-18145), which is merged. Test-only.
The fix routes both settlement paths through
gasFeeUsed(gasUsed, effectiveGasPrice, l1Fee), but only the revert path had a regression. The success path through the confirmer, which the finding names first, had none.l1Feemust storeexecution + l1Fee, and explicitly not the execution-only figure.effectiveGasPricemust leave the outbound PENDING with no cost recorded, rather than confirming a partial one. That guard also prevents a nil dereference.l1Feefrom the helper, and removing theeffectiveGasPriceguard, each fail.