test: F-2026-18199 | [Dual Defense] TSS Setup Message Signs an Unverified Hash (Payload vs SigningHash Split) - #312
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-2026-18199 follow-up: pin setup decoding across all protocols
Landed after #309 merged. No behaviour change beyond one widened check.
Why
setupBindsThresholdruns on quorumchange, which is built byDklsQcSetupMsgNew, a different constructor from keygen. Merged code exercised that path only in production, never in a test.What I did
TestSetupDecoders_AllProtocols, a matrix over the three setup shapes the coordinator builds: keygen (shared with keyrefresh), quorumchange, and sign (shared with fund migration).SetupThresholdto accept au16threshold as well asu8. The weighted keygen variant stores it asu16under the same tag, and the merged code would reject every setup rather than read it.Behaviour the matrix pins