fix: F-2026-18142 | [Dual Defense] Fund Migration Signing Hash Uses Live Balance and Is Raceable by Dust Inflows - #303
Merged
Merged
Conversation
… against live balance (F-2026-18142)
Member
Author
|
A much better approach is if core provides the transfer_amount
|
Admin supplies the observed balance; the keeper derives transfer_amount from it using the gas figures it fetches, stores it on the migration and emits it, so validators sign one pinned amount instead of re-deriving from a live balance. Rejects a balance that cannot cover its own fee.
Without them validSigner fails to parse and ValidateBasic returns on the signer check, so the balance assertions never ran.
Aman035
changed the title
Aman035
marked this pull request as ready for review
August 26, 2026 08:03
# Conflicts: # universalClient/chains/evm/tx_builder.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.