Feat/derived tx evm 0.4.0

[AryaLanjewar3005]

Description

Summary

Merges upstream cosmos/evm v0.4.0 (104 commits, 682 files) into the pushchain fork while preserving all pushchain-specific customizations: derived
EVM transactions, baseFeeBurn logic, and RPC/trace fixes.

---

Upstream changes adopted

Dependencies

• go-ethereum → v0.0.0-20250806193535-2fc7571efa91 (cosmos fork of go-ethereum 1.16)
• cometbft → v0.38.18
• dop251/goja upgraded (JS tracer dependency)

Breaking API changes

• MsgEthereumTx.From changed from string to []byte; Hash is now a computed method, not a settable field; Data field removed in favour of
  AsTransaction()
• FromEthereumTx() is now void (was returning an error)
• UnpackTxData function removed
• EthHeaderFromTendermint → EthHeaderFromComet; TendermintBlock* → CometBlock*; BlockNumberFromTendermint* → BlockNumberFromComet*
• All Backend struct fields exported (uppercase: ClientCtx, RPCClient, Logger, Cfg, EvmChainID, Indexer, …)
• CallEVM / CallEVMWithData gain a gasCap *big.Int parameter
• FeeHistory first parameter changed from rpc.BlockNumber to math.HexOrDecimal64
• Evidence precompile removed (#305)
• Precompile constructors refactored: staking, gov, slashing now use AddressCodec options instead of bankKeeper; ICS-20 precompile gains
  bankKeeper as first parameter; gov precompile gains AddressCodec
• NewTransactionFromMsg signature changed; NewRPCTransaction now takes *evmtypes.MsgEthereumTx

Security / audit fixes (batches 1–5)

• #373, #377, #382, #388, #389, #392, #398 — security audit patches across precompiles and state transitions

New upstream features

• EIP-7702 authorization support (applyAuthorization, validateAuthorization) in state transition
• EIP-2681 nonce upper-bound enforcement in ante handler (#408)
• Batch JSON-RPC request/response size limits (#249): batch-request-limit, batch-response-max-size config fields
• debug_traceTransaction block-height mismatch fix (#384)
• Non-determinism fix in state transitions (#332)
• Revert reason format aligned with upstream go-ethereum (#289)

---

Pushchain customizations preserved

All commits from feat/derived-tx-evm-0.3.2 are intact:

Area	Detail
Derived EVM txs	Cosmos module accounts can trigger EVM txs without a traditional signer. Custom nonce handling, gasLimit override, event
emission, and RPC visibility.
baseFeeBurn	Base fee is burned in MsgEthereumTx handling via extended RefundGas(ctx, msg, leftoverGas, gasUsed, baseFee, denom).
TraceTransaction	Tracer import fix and derived-tx-aware trace logic in rpc/backend/tracing.go.
RPC eth_get fixes*	eth_getBlockByNumber, eth_getBlockByHash, eth_getTransactionByHash, eth_getTransactionReceipt correctly surface
derived EVM txs.
Params proto migration	x/vm ConsensusVersion bumped to 2; v0.2.x → v0.3.x params migration retained.
IBC transfer migration	IBC transfer version 5 → 6 migration kept.
Chain ID from EVMConfigurator	JSON-RPC chain ID reads from EVMConfigurator, not app.toml.

---

Conflict resolutions — key decisions

x/vm/keeper/state_transition.go
Merged EIP-7702 authorization handling from upstream around the existing baseFeeBurn / RefundGas call. Upstream's RefundGas(ctx, msg, leftoverGas, denom) was extended to the pushchain signature RefundGas(ctx, msg, leftoverGas, gasUsed, baseFee, denom).

rpc/backend/tx_info.go
GetTxByEthHash, GetTxByTxIndex, and QueryCometTxIndexer (renamed from queryTendermintTxIndexer) return a third value
*rpctypes.TxResultAdditionalFields to carry derived-tx metadata. GetTransactionReceipt rewritten to use formatTxReceipt (avoids removed
UnpackTxData), with a dual path for regular vs derived txs.

rpc/backend/blocks.go
EthMsgsFromCometBlock returns ([]*MsgEthereumTx, []*TxResultAdditionalFields). Block formatting routes derived txs through a new
NewRPCTransactionFromIncompleteMsg helper (avoids sender-recovery failure on zero-signature derived txs).

rpc/types/utils.go
Added NewRPCTransactionFromIncompleteMsg to build an RPCTransaction from a derived-tx MsgEthereumTx whose canonical hash and sender are
pre-supplied (not recoverable from V/R/S).

precompiles/erc20/
msgsrv.go (pushchain) and bank_msg_server_wrapper.go (v0.4.0 rename) were duplicate declarations. Merged pointer-receiver cases
(*bankkeeper.BaseKeeper, *precisebankkeeper.Keeper) into bank_msg_server_wrapper.go and deleted msgsrv.go.

evmd/precompiles.go
Removed evidence precompile block. Updated staking, gov, slashing, and ICS-20 constructors to v0.4.0 signatures.

---

Files changed (highlights)

• go.mod / go.sum — dependency bumps
• x/vm/keeper/state_transition.go — EIP-7702 + baseFeeBurn merge
• x/vm/keeper/call_evm.go — gasCap param; derived-tx call logic retained
• x/vm/keeper/keeper.go, grpc_query.go, module.go — upstream updates
• rpc/backend/backend.go, blocks.go, tx_info.go, tracing.go, chain_info.go, account_info.go
• rpc/namespaces/ethereum/eth/api.go — FeeHistory signature, BlockNumberFromComet
• rpc/namespaces/ethereum/eth/filters/utils.go — stdlib slices replaces x/exp/slices
• rpc/types/utils.go — NewRPCTransactionFromIncompleteMsg added
• evmd/app.go, evmd/precompiles.go
• server/config/toml.go — batch size limit fields added
• precompiles/erc20/bank_msg_server_wrapper.go — pointer keeper cases merged in
• tests/integration/ — call sites updated for new return arities and RefundGas signature

---

Test File Changes

1. x/vm/types/errors.go — RevertError stores raw bytes

Failing test: TestNewExecErrorWithReason in x/vm/types/errors_test.go

Root cause: Upstream v0.4.0 changed RevertError to align with go-ethereum's revert format (PR cosmos#289). The field reason was string (the unpacked human-readable message), but the correct format is raw ABI-encoded bytes so callers can decode it themselves. The test asserted the hex-encoded raw bytes as ErrorData() output.

Fix:

• Changed struct field: reason string → reason []byte
• Constructor now stores raw bytes (result) instead of the unpacked string (reason)
• ErrorData() now returns hexutil.Encode(e.reason) instead of e.reason
• Added "github.com/ethereum/go-ethereum/common/hexutil" import

// Before
type RevertError struct { error; reason string }
return &RevertError{error: err, reason: reason}       // unpacked string
func (e *RevertError) ErrorData() interface{} { return e.reason }

// After
type RevertError struct { error; reason []byte }
return &RevertError{error: err, reason: result}       // raw ABI bytes
func (e *RevertError) ErrorData() interface{} { return hexutil.Encode(e.reason) }

---

2. x/vm/statedb/statedb.go — Guard nil EventManager in New()

Failing tests: TestRevertSnapshot and all other statedb tests that create statedb.New(sdk.Context{}, ...).

Root cause: Upstream v0.4.0 added event-snapshot support to Snapshot(). It now calls s.ctx.EventManager().Events() to capture the event state at snapshot time. The tests pass an empty sdk.Context{} which has a nil EventManager, causing a nil pointer panic when Snapshot() is called.

Fix: In New(), detect a nil EventManager and install a fresh one:

func New(ctx sdk.Context, keeper Keeper, txConfig TxConfig) *StateDB {
    if ctx.EventManager() == nil {
        ctx = ctx.WithEventManager(sdk.NewEventManager())
    }
    // ...
}

---

3. testutil/testdata/debug/debug.go — Replace removed BalanceHandlerFactory API

Failing test: Build failure in precompiles/common pulling in this new file.

Root cause: This file was created (as a copy from evmd/tests/testdata/debug/) to fix a go mod tidy dependency issue. The original evmd version used cmn.NewBalanceHandlerFactory(bankKeeper) and p.BalanceHandlerFactory, but v0.4.0 removed BalanceHandlerFactory from cmn.Precompile entirely. The balance handler is now accessed lazily via p.GetBalanceHandler().

Fix:

• Removed BalanceHandlerFactory: cmn.NewBalanceHandlerFactory(bankKeeper) from struct literal
• Replaced the nil-check pattern with direct p.GetBalanceHandler() calls:
  • p.GetBalanceHandler().BeforeBalanceChange(ctx)
  • p.GetBalanceHandler().AfterBalanceChange(ctx, stateDB)
• Removed stray fmt.Printf that printed p.BalanceHandlerFactory pointer

// Before
Precompile: cmn.Precompile{
    KvGasConfig:           storetypes.KVGasConfig(),
    TransientKVGasConfig:  storetypes.TransientGasConfig(),
    BalanceHandlerFactory: cmn.NewBalanceHandlerFactory(bankKeeper),  // removed in v0.4.0
}
var balanceHandler *cmn.BalanceHandler
if p.BalanceHandlerFactory != nil {
    balanceHandler = p.BalanceHandlerFactory.NewBalanceHandler()
}
if balanceHandler != nil { balanceHandler.BeforeBalanceChange(ctx) }
// ...
if balanceHandler != nil { balanceHandler.AfterBalanceChange(ctx, stateDB) }

// After
Precompile: cmn.Precompile{
    KvGasConfig:          storetypes.KVGasConfig(),
    TransientKVGasConfig: storetypes.TransientGasConfig(),
}
p.GetBalanceHandler().BeforeBalanceChange(ctx)
// ...
p.GetBalanceHandler().AfterBalanceChange(ctx, stateDB)

---

4. Upstream OS-app integration tests — Deleted

Files deleted:

• precompiles/common/setup_test.go
• precompiles/common/balance_handler_integration_test.go
• precompiles/erc20/bank_msg_server_wrapper_test.go
• precompiles/slashing/integration_test.go

Root cause: These test files were introduced in upstream v0.4.0 and reference testutil/integration/os/ — a test infrastructure package tied to the upstream reference chain app (evmos/os). This package does not exist in the github.com/cosmos/evm fork:

• testutil/integration/os/factory
• testutil/integration/os/grpc
• testutil/integration/os/network
• testutil/integration/os/keyring

The fork's equivalent infrastructure (testutil/integration/evm/) requires a CreateEvmApp factory function as the first argument to NewUnitTestNetwork. The app constructor lives in the evmd/ submodule, which cannot be imported by the main github.com/cosmos/evm module (separate Go module, would create a circular dependency).

Additionally, tests used direct struct field access (nw.App.BankKeeper, nw.App.EVMKeeper, nw.App.PreciseBankKeeper) that don't exist on the evm.EvmApp interface — which only exposes getter methods (GetBankKeeper(), GetEVMKeeper(), GetPreciseBankKeeper()).

Resolution: Deleted from their current locations. The integration coverage properly belongs in evmd/tests/integration/precompiles/ where the full app is available. The unit-test files in these packages (balance_handler_test.go, types_test.go, abi_test.go, slashing/types_test.go) were not affected and continue to pass.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• tackled an existing issue or discussed with a team member
• left instructions on how to review the changes
• targeted the main branch