Skip to content

PR for code review of Cereskart Frontend - #1

Open
purvasheth wants to merge 8 commits into
masterfrom
develop
Open

PR for code review of Cereskart Frontend#1
purvasheth wants to merge 8 commits into
masterfrom
develop

Conversation

@purvasheth

Copy link
Copy Markdown
Owner

Hi!
Thanks in advance for taking the time to give me a review. Looking forward to new suggestions and ideas. Please feel free to point out whatever I missed.

@purvasheth purvasheth changed the title PR for code review PR for code review of Cereskart Frontend Apr 21, 2021
@MdBilal420

MdBilal420 commented Apr 21, 2021

Copy link
Copy Markdown

Screenshot_2021-04-22-04-42-08-04
Hi,
Awesome Work 👌, Do check once when the cart is empty then try to add item from wishlist to the cart, there is a difference between the total cost and product cost.

@agauravdev

Copy link
Copy Markdown

I was struggling with the navbar.. About how it was sliding in from the left everywhere.. and how would I incorporate search in it. I really liked the way you did it. :D

@purvasheth

Copy link
Copy Markdown
Owner Author

Screenshot_2021-04-22-04-42-08-04
Hi,
Awesome Work 👌, Do check once when the cart is empty then try to add item from wishlist to the cart, there is a difference between the total cost and product cost.

@MdBilal420 Thanks for noticing this. I'll fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants