Repository navigation
Conversation
Align Button docs with the Canvas Kit accessibility template: structure, built-in behaviors, requirements table, and anti-patterns scoped to variant buttons with correct Segmented Control and icon-only naming guidance. Co-authored-by: Cursor <cursoragent@cursor.com>
Expand the Action Bar accessibility docs to match the Button/Menu pattern: minimum structure, built-in behaviors (overflow, keyboard, screen reader), requirements table, and anti-patterns. Make plain MDX table cells opaque in Storybook so inline code is distinguishable from zebra striping. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
|
Superseded by Workday#4189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: N/A (docs initiative: accessibility guidance for AI codegen)
Rewrites the
## Accessibilitysection ofActionBar.mdxto follow the pattern used by the Button and Menu docs: intro and related-component links, minimum accessible structure, built-in behaviors (including overflow, keyboard, and screen reader expectations), an accessibility requirements table with a "no design spec" default and REQUIRED/CONDITIONAL summary, and anti-patterns. Every ARIA/focus claim was checked againstmodules/react/action-bar/liband the Menu/collection hooks. The Open/close focus table is omitted because Action Bar is not an overlay.Also adds a small Storybook docs style (
.storybook/preview-head.html) that makes plain MDX table cells opaque. Storybook's zebra striping used the same color as inlinecode, so code pills were indistinguishable in the new requirements table. The Component API tables already had opaque cells, so this makes the MDX tables consistent with them.Release Category
Documentation
Checklist
ready for reviewhas been added to PRWhere Should the Reviewer Start?
modules/react/action-bar/stories/ActionBar.mdx(Accessibility section). The Storybook CSS change is in.storybook/preview-head.html.Areas for Feedback? (optional)
Code
Documentation
Testing
Codemods
This branch is stacked on the Button accessibility rewrite (docs(button): Expand accessibility section for AI codegen Workday/canvas-kit#4183), so the diff also shows
Button.mdx. That file will drop out once docs(button): Expand accessibility section for AI codegen Workday/canvas-kit#4183 merges.The
.storybook/preview-head.htmlrule affects every plain MDX table in Storybook docs; please confirm that is acceptable.Design-system page guidance was not fetched; behavior is derived from source.
Testing Manually
Run
yarn start, open Components / Buttons / Action Bar / Docs, and review the Accessibility section: tables render with opaque cells, inline code is distinguishable, and links resolve (Modal and Dialog links in particular).