docs: include details on how downstream products can use the rust release workflow - #36
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe change documents the reusable Rust release workflow, adds caller guidance, updates README content, allows direct documentation files under ChangesRust release workflow documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/zizmor.yml:
- Around line 7-13: Update both adjacent explanatory comments in the
stale-action-refs configuration to reference release-rust.yml:257 instead of
release-rust.yml:250, keeping the existing ignore entries and rationale
unchanged.
In `@docs/release-rust.md`:
- Around line 100-103: Update step 2 of the Adoption checklist to reference the
configured environment input rather than hard-coding “release”; preserve the
default value of “release” while making the instruction apply when callers
override it, and include the required reviewer setup for that selected
environment.
- Line 81: Update the release documentation around the checksum generation
command to explicitly state that checksums.txt covers the assets already present
in dist and excludes itself, while separately preserving the statement that
attestations cover every asset, including checksums.txt.
- Line 86: Update the release documentation’s version guidance to make the
source explicit: require Cargo.toml’s package version to match the release tag,
or instruct tag-derived values to use github.ref_name. Remove the claim that the
release tag is available through CARGO_PKG_VERSION, while preserving the
shallow-checkout and git-history constraint.
In `@README.md`:
- Line 6: Update the README release-workflow description to replace “no
per-project security plumbing” with precise wording limited to the absence of
per-project secrets and signing-key management, while preserving the existing
SLSA and keyless Sigstore claims.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ae44afb5-a20d-46b4-868a-41a65da19483
📒 Files selected for processing (4)
.github/zizmor.yml.gitignoreREADME.mddocs/release-rust.md
…ease workflow Closes #14 Signed-off-by: purpleclay <purpleclaygh@gmail.com>
5eec7f3 to
7e33c74
Compare
closes #14
Summary by CodeRabbit
docs/directory.