feat: enforce block-mode egress for release-rust's plan and build jobs (#30) - #32
Closed
purpleclay wants to merge 1 commit into
Closed
feat: enforce block-mode egress for release-rust's plan and build jobs (#30)#32purpleclay wants to merge 1 commit into
purpleclay wants to merge 1 commit into
Conversation
#30) Closes #23 `build`'s harden_runner moves from audit to block, with the allowed endpoints computed per matrix leg rather than static: - `plan` now assembles two endpoint sets — one for zigbuild (linux) legs, one for native (macOS) legs — and bakes the appropriate one into each matrix entry alongside runs-on/zigbuild, verified against real harden-runner audit logs rather than guessed - the zig mirror allowlist is fetched live from ziglang.org's own authoritative mirror list, since mlugg/setup-zig picks a mirror at random per run (confirmed: two real runs picked two different ones) — allowlisting whichever one we'd happened to observe would have been incomplete - `plan` gets its own harden_runner (block, ziglang.org only), since fetching that mirror list is the first time this job reaches the network Signed-off-by: purpleclay <purpleclaygh@gmail.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughChangesRelease egress hardening
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant PlanJob
participant ZigUpstream
participant ReviewedList
participant BuildMatrix
participant BuildRunner
PlanJob->>ZigUpstream: Fetch live community mirrors
PlanJob->>ReviewedList: Read committed reviewed mirrors
PlanJob->>BuildMatrix: Pass the live/reviewed intersection
BuildMatrix->>BuildRunner: Apply target-specific allowed endpoints
BuildRunner-->>PlanJob: Build with blocked egress
Possibly related issues
Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #31
Summary by CodeRabbit
Security
Reliability
Documentation