upstream changes - #10
Open
Kreavita wants to merge 3 commits into
Open
Conversation
… data that has been already collected
Contributor
Author
|
this is not really what I intended to do, but oh well. |
Contributor
Author
|
if its fine for you we can repurpose this pull request and I can implement changes to download your own match history when called without name argument (make it optional), and we can either leave the name argument in the code and broken, figure out if we can obtain a |
Owner
|
Hi, I would be down to make it optional or do it by PUUID, if you could post a console trace of it working and exporting, I would be happy to merge.
I haven't played league in years, so this is more just up here for other people to reference, but if it can continue to work, that would be great.
…On Wednesday, April 15th, 2026 at 3:02 PM, Kreavita ***@***.***> wrote:
Kreavita left a comment [(purarue/lolexport#10)](#10 (comment))
if its fine for you we can repurpose this pull request and I can implement changes to download your own match history when called without name argument (make it optional), and we can either leave the name argument in the code and broken, figure out if we can obtain a puuid by summoner id or just remove the functionality.
—
Reply to this email directly, [view it on GitHub](#10 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AB3RO52RKTKDC3S47FZZHGL4WABHRAVCNFSM6AAAAACX2Y3NXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DENJVHEYDIMZVGI).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.