Add support for cert-authority - #107
Open
bwitt wants to merge 1 commit into
Open
Conversation
bwitt
force-pushed
the
bwitt/cert-authority
branch
3 times, most recently
from
August 22, 2026 05:57
65df3f6 to
b2266a5
Compare
Author
|
@jst-cyr would it be possible to get this one reviewed? thanks! |
bwitt
force-pushed
the
bwitt/cert-authority
branch
from
August 22, 2026 06:19
b2266a5 to
15bf928
Compare
Signed-off-by: Brian Witt <brianwitt@gmail.com>
bwitt
force-pushed
the
bwitt/cert-authority
branch
from
August 22, 2026 06:43
15bf928 to
7787717
Compare
Member
|
Running CI tests for this PR here: #117 |
Member
|
@deric : This one requires somebody from our Phoenix engineering team to do the code review. I did kick off the acceptance testing and the results are all green. Acceptance tests: https://github.com/puppetlabs/puppetlabs-sshkeys_core/actions/runs/32731008083 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
ssh_keytypecert-authorityby using a newmarkerparamAdd tests and acceptance test too.
Example:
results in
Fixes #89