Fix: Ensure mod_md tls-alpn-01 challenge is usable - #2643
Open
JonasVerhofste wants to merge 1 commit into
Open
Conversation
The challenge is already configurable in apache::mod::md, but it needs the `acme-tls/1` protocol to properly work (see "https: Challenges"): https://httpd.apache.org/docs/2.4/mod/mod_md.html Signed-off-by: Jonas Verhofsté <jonas@verhofste.tech>
JonasVerhofste
requested review from
a team,
bastelfreak,
ekohl and
smortex
as code owners
August 18, 2026 16:59
Author
|
That looks like a CI bug, not a failed test. 😅 |
Member
|
@JonasVerhofste : You are right, the acceptance tests don't run correctly on forks. Initial spec tests look good, I'll run some acceptance tests so we can get platform-specific feedback. |
Member
|
Running CI tests for this PR here: #2644 |
Member
|
Acceptance test results here: https://github.com/puppetlabs/puppetlabs-apache/actions/runs/32295187776?pr=2644 All failures in PR acceptance testing match existing failures in the Nightly build against main:
These are pre-existing issues on main, not caused by this change. Next step will require an engineering review when the team is available, but tests look good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The challenge is already configurable in apache::mod::md, but it needs the
acme-tls/1protocol to properly work (see "https: Challenges"): https://httpd.apache.org/docs/2.4/mod/mod_md.html