Move expectation out of let block - #2558
Open
ekohl wants to merge 2 commits into
Open
Conversation
kenyon
approved these changes
Aug 16, 2024
ekohl
commented
Aug 17, 2024
| it { | ||
| expect(subject).to contain_concat__fragment('rspec.example.com-apache-userdir') | ||
| .with(content: %r{^\s+UserDir disabled$}) | ||
| .with(content: %r{^\s+UUserDir enabled bob$}) |
Collaborator
Author
There was a problem hiding this comment.
Looks like there was already a typo in UUserDir here, which is proof the test didn't ran.
bastelfreak
previously approved these changes
Aug 17, 2024
smortex
approved these changes
Sep 13, 2024
Otherwise it isn't executed. Fixes: ec74a8e ("Add support for setting UserDir in Virtual Hosts")
Member
|
Running CI tests for this PR here: #2647 |
Member
|
Acceptance test results for this PR: https://github.com/puppetlabs/puppetlabs-apache/actions/runs/33202661914?pr=2647 All red platforms (SLES-12, SLES-15, Debian-13) match pre-existing failures on the nightly main build. SLES-12 is a known provisioning flake affecting all modules, and SLES-15/Debian-13 fail identically on nightly with the same spec and error (apache2ctl missing on SLES-15, apache2 systemd start failure on Debian-13). None of these are caused by this PR. From a testing perspective, looks good. Needs engineering review when available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Otherwise it isn't executed.
Related Issues (if any)
Fixes: ec74a8e ("Add support for setting UserDir in Virtual Hosts")
Checklist
puppet apply)