Update setenvif.conf to follow upstream changes - #2534
Conversation
|
|
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Definitively not an "upsteam" change, but the custom config of ubuntu on top of the custom config of debian for mod_setenvif seems to match the example configuration of mod_dav upsteam:
So LGTM, but there are a few more entries that seems to be incorrect and that we can sync with upsteam. I added in-line comments to them.
| BrowserMatch "^WebDrive" redirect-carefully | ||
| BrowserMatch "^WebDAVFS/1.[0123]" redirect-carefully | ||
| BrowserMatch "^gnome-vfs/1.0" redirect-carefully | ||
| BrowserMatch "^WebDAVFS/1\.[012]" redirect-carefully |
There was a problem hiding this comment.
Is it on purpose that 1.3 was dropped here?
There was a problem hiding this comment.
I think so: upstream switched from 1.[01234] to 1\.[012]:
https://svn.apache.org/viewvc/httpd/httpd/trunk/docs/conf/extra/httpd-dav.conf.in?r1=1915651&r2=1915650&pathrev=1915651
This brings the file closer to the upstream contents as of https://git.launchpad.net/ubuntu/+source/apache2/commit/debian/config-dir/mods-available/setenvif.conf?id=696485dab93b0a8de434f051e2b85134d342dc33
Co-authored-by: Romain Tartière <romain@blogreen.org>
Co-authored-by: Romain Tartière <romain@blogreen.org>
|
Hey there @mpdude, sorry that there hasn't been any activity to push this forward in so long. It looks like the changes were reviewed and approved and I've just now rebased so it can run the tests against the latest in main. Is this still a PR you'd like to see move forward? I'm going through old PRs and trying to identify ones we should prioritize or just close down. |
|
Yes... or should I recheck for newer upstream changes that happened since then? |
6 participants
This brings the file closer to the upstream contents as of
https://git.launchpad.net/ubuntu/+source/apache2/commit/debian/config-dir/mods-available/setenvif.conf?id=696485dab93b0a8de434f051e2b85134d342dc33
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)