Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

String passed by reference #29

Open
Open
String passed by reference#29

Description

@VitoNordloh
VitoNordloh
opened on Oct 25, 2017

pt_extlist/Classes/Domain/Renderer/Default/CellRenderer.php

Line 158 in 6501290

$specialValues = GeneralUtility::callUserFunction($rendererUserFunc, $cell, '');

The GeneralUtility::callUserFunction function expects the third parameter to be a value by reference.

At the moment PHP throws a fatal error:

Fatal error: Only variables can be passed by reference in /homepages/***/***/htdocs/website/typo3conf/ext/pt_extlist/Classes/Domain/Renderer/Default/CellRenderer.php on line 159

A quick and dirty fix is

$_fix = '';
$specialValues = GeneralUtility::callUserFunction($rendererUserFunc, $cell, $_fix);

I don't know what goes on under the hood, but maybe it would be better to simply pass $this?

Activity

  2. VitoNordloh commented on Nov 10, 2017

    @VitoNordloh
    VitoNordloh
    on Nov 10, 2017
    Author

    Reference to be passed along (typically "$this" - being a reference to the calling object) (REFERENCE!)

    The Typo3 documentation says explicit that one should pass a reference. Maybe we should indeed just pass $this according to your and the documentations suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions