Repository navigation
Update the role for Ansible>12 - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the Ansible role to remove deprecated Ansible features and modernize the code to use current best practices. The changes align with Ansible's recommended patterns for accessing facts and module parameters.
Changes:
- Migrated from deprecated top-level Ansible fact variables (like
ansible_system,ansible_os_family,ansible_distribution_release) to theansible_factsdictionary approach - Updated PostgreSQL module parameters from deprecated
dbtologin_db - Removed redundant
vars.prefix in variable references - Added Debian 13 to supported operating systems and updated documentation generation comments
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/users.yaml | Updated PostgreSQL user module to use login_db instead of deprecated db parameter; removed redundant login_user parameter |
| tasks/main.yaml | Migrated conditional statements to use ansible_facts dictionary instead of deprecated top-level variables |
| defaults/main.yaml | Updated variable references and Jinja2 conditionals to use ansible_facts dictionary; removed redundant vars. prefix |
| README.md | Added documentation generation notice and Debian 13 to supported OS list |
| .aar-doc.yml | Updated template to include documentation generation notice and Debian 13 support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
medanthelinium
requested changes
Feb 9, 2026
medanthelinium
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Please also feel free to remove meta/.requirements.yml similar to the other roles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.