fix(deps): upgrade mcp-proxy to 6.7.13 and drop the WWW-Authenticate workaround - #359
Merged
Conversation
|
🎉 This PR is included in version 4.20.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #358 / #357. The real bug was in mcp-proxy, now fixed upstream in punkpeye/mcp-proxy#101 (released as 6.7.13): a 401 always carries a
WWW-Authenticatechallenge, OAuth config or not.mcp-proxy^6.4.6→^6.7.13(the lockfile was pinned at 6.4.6, three minors behind).oauth: {}shim Emit WWW-Authenticate on 401 when authenticate() fails with no OAuth config #358 added purely to unblock that header.#httpStreamOAuthConfig()stays, now doing only what its name says: advertiseresource_metadatawhen OAuth is enabled.Content-Typeon JSON/SSE responses to include; charset=utf-8(deliberate upstream fix for clients that decode unqualified JSON as Latin-1). Four OAuth metadata assertions pinned the exact string; they now match the media type and leave the charset to mcp-proxy.Verified the 401 behaviour is unchanged without the shim — header,
error_description, and the JSON-RPCidecho are byte-identical to #358, and the OAuth-enabled path still advertisesresource_metadata. 758/758 tests pass.