Repository navigation
Read either minus sign in Dialogue's sensitivity and the Leveler's percent knobs - #26
Merged
Merged
Conversation
…rcent knobs Both parsers kept only ASCII signs, so a typed or pasted "−50%" (U+2212, the sign the interfaces display) read as +50%. Dialogue's sensitivity runs from −100% to +100%, so this flipped the value, and the interface's own text didn't read back. Both now use ui::format::parseLenient, like the dB fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found during the shared-code consolidation (#22) and left out of it because it changes behaviour.
getValueForTextkept only ASCII+-, so "−50%" with U+2212, the sign Dialogue displays, read as +50%. The displayed text didn't read back either.ui::format::parseLenient, which the dB fields already use.Testing
[params]test: "-50%", "−50%" and "− 50 %" all read −0.5, "+25%" reads 0.25, and the displayed text for −40% reads back.🤖 Generated with Claude Code