Repository navigation
Fix the Leveler and Dialogue release builds - #20
Merged
Merged
Conversation
- leveler: voicing.hpp used size_t without <cstddef>; the release builds on Linux (clang 21, no precompiled JUCE headers in front of it) failed - dialogue: its LV2 tag is "utility"; packaging/patch_lv2.py has no "util", which failed the Windows release build (the test workflow doesn't build LV2 there) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
leveler-v0.1.0anddialogue-v0.1.0release runs failed to build:voicing.hppusedsize_twithout<cstddef>. Nowstd::size_twith the include.LV2_TAGS util, butpackaging/patch_lv2.pyonly knowsutility. The test workflow doesn't build LV2 on Windows, so it never ran there.Once this is merged, both tags move to the merge commit. No release was created from them.
Testing
voicing.cppcompiles on its own with clang 21.Review
Two small fixes; no behaviour change.
🤖 Generated with Claude Code