refactor(layouts): unify product and event pages on template-page layout - #20487
Conversation
Rename the product-page layout to template-page and migrate the KubeCon and Google Cloud Next event pages from the bespoke event-page layout to the shared sections-array system, deleting the event-page layout and its orchestrator partial. Also: - Move generic partials out of template-partials/ (code-snippets, mini-cards, external-link-attrs, events/event-card) per the new naming convention documented in template-page-content.html - Consolidate case-studies/toc.html and template-sidebar-nav.html into a shared section-toc.html partial (case studies + whitepapers), with the scrollspy hook renamed to data-section-toc - Inline the card.html and template-card.html partials into their only callers (card-group.html, template-two-column.html, proserv.html) and delete them along with card-group-toggled.html, card-button-download.html, and the unused icon_style: black option - Replace padding-hack aspect ratios with Tailwind aspect-* utilities and fix stale i selectors to target .ph-icon sprite icons - Update AGENTS.md, event page guides, the figma-to-template-page skill, and the case-studies archetype for the new names Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Your site preview for commit cf5e3e5 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-20487-cf5e3e51.s3-website.us-west-2.amazonaws.com Changed pages: |
Lighthouse Performance ReportCommit: cf5e3e5 | Metric definitions
|
Pre-merge Review — Last updated 2026-07-24T13:58:38ZTip Summary: This is a layout refactor that migrates Pulumi's product and event marketing pages — the two event landing pages ( Review confidence:
Investigation log
🔍 Verification trail58 claims extracted · 38 verified · 5 unverifiable · 3 contradicted
🚨 Outstanding in this PRNo outstanding issues in this PR. Every flagged claim is pre-existing content reproduced verbatim by this refactor — see 💡 Pre-existing.
|
Resolve conflict in template-hero.html: keep the renamed external-link-attrs.html partial path from this branch and the data-role="cta-secondary" A/B test attribute from master (#20347). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
cnunciato
left a comment
There was a problem hiding this comment.
will be be creating more event landing pages in the future? If not, can the two we have be removed and redirected to standard event pages?
I doubt it, but let's hold onto these two just because they're our two largest, and having this extra marketing surface for them isn't necessarily hurting us.
…page-redesign Two conflicts, both from master's #20487 layout refactor overlapping this branch's events redesign: - layouts/partials/events/list-section.html: master renamed template-partials/template-event-card.html to events/event-card.html and passes an "upcoming" flag. Took master's new partial path with this branch's parameter set: the redesigned card derives its CTA from the event's youtube_url, and the list only renders events that are upcoming or have a recording, so "not on-demand" is equivalent to "upcoming" and the flag is redundant. - theme/src/scss/_templates.scss: kept this branch's font-overline month header and dropped master's .template-event-card / .event-card-grid blocks. The redesigned card composes .card / .card-hover / .badge / .btn instead, so none of those class names are referenced anywhere in the merged tree. Git resolved the card itself as a rename, carrying this branch's changes onto master's new path; master's edit there was a pure move with no content change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Just some organization and refactoring of stuff that was bugging me. Event landing pages now use the same shared template system as product and parter pages. It's also renamed to
template-pageto make it's actual usage more clear (can be used for content other than product pages.)To think about for future work: will be be creating more event landing pages in the future? If not, can the two we have be removed and redirected to standard event pages?
Proposed changes
Renames the
product-pagelayout totemplate-pageand migrates the KubeCon and Google Cloud Next event pages from the bespokeevent-pagelayout onto the sharedsections:array system, deleting the old layout and its orchestrator partial. Generic partials move out oftemplate-partials/(code-snippets, mini-cards, external-link-attrs, events/event-card) per the naming convention now documented intemplate-page-content.html, and the case-study TOC and whitepaper sidebar nav consolidate into a sharedsection-toc.htmlwith a renameddata-section-tocscrollspy hook. Dead partials (card.html,template-card.html,card-group-toggled.html,card-button-download.html) are inlined into their only callers or deleted, withproserv.htmlrewritten to stand alone on shared.card/.btnstyles, and the unusedicon_style: blackoption removed. Padding-hack aspect ratios are replaced with Tailwindaspect-*utilities, and staleiselectors now target the.ph-iconsprite icons. AGENTS.md, the event page guides, the figma-to-template-page skill, and the case-studies archetype are updated for the new names; verified with a full local Hugo build, including production-parity checks on/proserv/.