Fail crossbuild loudly when Windows signing silently skips

provider-ci/internal/pkg/templates/base/scripts/crossbuild.mk

@@ -59,6 +59,12 @@ bin/%/$(PROVIDER) bin/%/$(PROVIDER).exe: bin/jsign-7.4.jar
 		fi; \
 	fi
 
+	@# Verify the windows binary was actually signed when signing was expected.
+	@# This runs in its own shell as a separate recipe line, so make checks its
+	@# exit code directly (no set-e-inside-if antipattern). Catches the silent
+	@# failure where the signing block above exits 0 without producing a signature.
+	@[ "${GOOS}" != "windows" ] || [ "${SKIP_SIGNING}" = "true" ] || python3 scripts/verify_signed.py "$@"
+
 bin/jsign-7.4.jar:
 	wget https://github.com/ebourg/jsign/releases/download/7.4/jsign-7.4.jar --output-document=bin/jsign-7.4.jar
 

provider-ci/internal/pkg/templates/base/scripts/verify_signed.py

@@ -0,0 +1,51 @@
+"""Verify a Windows PE binary has an Authenticode signature attached.
+
+Presence check only: parses the PE Optional Header's Certificate Table
+directory entry and exits 0 if it is non-empty, non-zero otherwise. Does
+not validate the certificate chain or the signature itself; full chain
+validation is the verify-release workflow's job.
+
+Purpose: catch the silent-failure pattern in scripts/crossbuild.mk where
+the signing block exits 0 without producing a signature (e.g. a future
+regression that returns the recipe to /bin/sh and silently skips the
+bash conditional).
+
+Usage: python3 scripts/verify_signed.py <path-to-exe>
+"""
+
+import struct
+import sys
+
+
+def main(argv: list[str]) -> int:
+    if len(argv) != 2:
+        print(
+            f"usage: {argv[0]} <path-to-exe>",
+            file=sys.stderr,
+        )
+        return 2
+    path = argv[1]
+    with open(path, "rb") as f:
+        data = f.read()
+
+    # PE header offset is stored at 0x3C.
+    pe = struct.unpack_from("<I", data, 0x3C)[0]
+    # Optional header Magic: 0x10B = PE32, 0x20B = PE32+.
+    magic = struct.unpack_from("<H", data, pe + 24)[0]
+    # DataDirectory starts at +96 (PE32) or +112 (PE32+) of optional header.
+    # Certificate Table is index 4; each entry is 8 bytes (VirtualAddress, Size).
+    dd_start = pe + 24 + (96 if magic == 0x10B else 112)
+    cert_size = struct.unpack_from("<I", data, dd_start + 4 * 8 + 4)[0]
+
+    if cert_size == 0:
+        print(
+            f"ERROR: {path} has no Authenticode signature attached. "
+            "The signing step in crossbuild.mk silently failed.",
+            file=sys.stderr,
+        )
+        return 1
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main(sys.argv))

provider-ci/test-providers/aws/scripts/crossbuild.mk

@@ -59,6 +59,12 @@ bin/%/$(PROVIDER) bin/%/$(PROVIDER).exe: bin/jsign-7.4.jar
 		fi; \
 	fi
 
+	@# Verify the windows binary was actually signed when signing was expected.
+	@# This runs in its own shell as a separate recipe line, so make checks its
+	@# exit code directly (no set-e-inside-if antipattern). Catches the silent
+	@# failure where the signing block above exits 0 without producing a signature.
+	@[ "${GOOS}" != "windows" ] || [ "${SKIP_SIGNING}" = "true" ] || python3 scripts/verify_signed.py "$@"
+
 bin/jsign-7.4.jar:
 	wget https://github.com/ebourg/jsign/releases/download/7.4/jsign-7.4.jar --output-document=bin/jsign-7.4.jar
 

provider-ci/test-providers/aws/scripts/verify_signed.py

@@ -0,0 +1,51 @@
+"""Verify a Windows PE binary has an Authenticode signature attached.
+
+Presence check only: parses the PE Optional Header's Certificate Table
+directory entry and exits 0 if it is non-empty, non-zero otherwise. Does
+not validate the certificate chain or the signature itself; full chain
+validation is the verify-release workflow's job.
+
+Purpose: catch the silent-failure pattern in scripts/crossbuild.mk where
+the signing block exits 0 without producing a signature (e.g. a future
+regression that returns the recipe to /bin/sh and silently skips the
+bash conditional).
+
+Usage: python3 scripts/verify_signed.py <path-to-exe>
+"""
+
+import struct
+import sys
+
+
+def main(argv: list[str]) -> int:
+    if len(argv) != 2:
+        print(
+            f"usage: {argv[0]} <path-to-exe>",
+            file=sys.stderr,
+        )
+        return 2
+    path = argv[1]
+    with open(path, "rb") as f:
+        data = f.read()
+
+    # PE header offset is stored at 0x3C.
+    pe = struct.unpack_from("<I", data, 0x3C)[0]
+    # Optional header Magic: 0x10B = PE32, 0x20B = PE32+.
+    magic = struct.unpack_from("<H", data, pe + 24)[0]
+    # DataDirectory starts at +96 (PE32) or +112 (PE32+) of optional header.
+    # Certificate Table is index 4; each entry is 8 bytes (VirtualAddress, Size).
+    dd_start = pe + 24 + (96 if magic == 0x10B else 112)
+    cert_size = struct.unpack_from("<I", data, dd_start + 4 * 8 + 4)[0]
+
+    if cert_size == 0:
+        print(
+            f"ERROR: {path} has no Authenticode signature attached. "
+            "The signing step in crossbuild.mk silently failed.",
+            file=sys.stderr,
+        )
+        return 1
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main(sys.argv))

provider-ci/test-providers/cloudflare/scripts/crossbuild.mk

@@ -59,6 +59,12 @@ bin/%/$(PROVIDER) bin/%/$(PROVIDER).exe: bin/jsign-7.4.jar
 		fi; \
 	fi
 
+	@# Verify the windows binary was actually signed when signing was expected.
+	@# This runs in its own shell as a separate recipe line, so make checks its
+	@# exit code directly (no set-e-inside-if antipattern). Catches the silent
+	@# failure where the signing block above exits 0 without producing a signature.
+	@[ "${GOOS}" != "windows" ] || [ "${SKIP_SIGNING}" = "true" ] || python3 scripts/verify_signed.py "$@"
+
 bin/jsign-7.4.jar:
 	wget https://github.com/ebourg/jsign/releases/download/7.4/jsign-7.4.jar --output-document=bin/jsign-7.4.jar
 

provider-ci/test-providers/cloudflare/scripts/verify_signed.py

@@ -0,0 +1,51 @@
+"""Verify a Windows PE binary has an Authenticode signature attached.
+
+Presence check only: parses the PE Optional Header's Certificate Table
+directory entry and exits 0 if it is non-empty, non-zero otherwise. Does
+not validate the certificate chain or the signature itself; full chain
+validation is the verify-release workflow's job.
+
+Purpose: catch the silent-failure pattern in scripts/crossbuild.mk where
+the signing block exits 0 without producing a signature (e.g. a future
+regression that returns the recipe to /bin/sh and silently skips the
+bash conditional).
+
+Usage: python3 scripts/verify_signed.py <path-to-exe>
+"""
+
+import struct
+import sys
+
+
+def main(argv: list[str]) -> int:
+    if len(argv) != 2:
+        print(
+            f"usage: {argv[0]} <path-to-exe>",
+            file=sys.stderr,
+        )
+        return 2
+    path = argv[1]
+    with open(path, "rb") as f:
+        data = f.read()
+
+    # PE header offset is stored at 0x3C.
+    pe = struct.unpack_from("<I", data, 0x3C)[0]
+    # Optional header Magic: 0x10B = PE32, 0x20B = PE32+.
+    magic = struct.unpack_from("<H", data, pe + 24)[0]
+    # DataDirectory starts at +96 (PE32) or +112 (PE32+) of optional header.
+    # Certificate Table is index 4; each entry is 8 bytes (VirtualAddress, Size).
+    dd_start = pe + 24 + (96 if magic == 0x10B else 112)
+    cert_size = struct.unpack_from("<I", data, dd_start + 4 * 8 + 4)[0]
+
+    if cert_size == 0:
+        print(
+            f"ERROR: {path} has no Authenticode signature attached. "
+            "The signing step in crossbuild.mk silently failed.",
+            file=sys.stderr,
+        )
+        return 1
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main(sys.argv))

provider-ci/test-providers/docker/scripts/crossbuild.mk

@@ -59,6 +59,12 @@ bin/%/$(PROVIDER) bin/%/$(PROVIDER).exe: bin/jsign-7.4.jar
 		fi; \
 	fi
 
+	@# Verify the windows binary was actually signed when signing was expected.
+	@# This runs in its own shell as a separate recipe line, so make checks its
+	@# exit code directly (no set-e-inside-if antipattern). Catches the silent
+	@# failure where the signing block above exits 0 without producing a signature.
+	@[ "${GOOS}" != "windows" ] || [ "${SKIP_SIGNING}" = "true" ] || python3 scripts/verify_signed.py "$@"
+
 bin/jsign-7.4.jar:
 	wget https://github.com/ebourg/jsign/releases/download/7.4/jsign-7.4.jar --output-document=bin/jsign-7.4.jar
 

provider-ci/test-providers/docker/scripts/verify_signed.py

@@ -0,0 +1,51 @@
+"""Verify a Windows PE binary has an Authenticode signature attached.
+
+Presence check only: parses the PE Optional Header's Certificate Table
+directory entry and exits 0 if it is non-empty, non-zero otherwise. Does
+not validate the certificate chain or the signature itself; full chain
+validation is the verify-release workflow's job.
+
+Purpose: catch the silent-failure pattern in scripts/crossbuild.mk where
+the signing block exits 0 without producing a signature (e.g. a future
+regression that returns the recipe to /bin/sh and silently skips the
+bash conditional).
+
+Usage: python3 scripts/verify_signed.py <path-to-exe>
+"""
+
+import struct
+import sys
+
+
+def main(argv: list[str]) -> int:
+    if len(argv) != 2:
+        print(
+            f"usage: {argv[0]} <path-to-exe>",
+            file=sys.stderr,
+        )
+        return 2
+    path = argv[1]
+    with open(path, "rb") as f:
+        data = f.read()
+
+    # PE header offset is stored at 0x3C.
+    pe = struct.unpack_from("<I", data, 0x3C)[0]
+    # Optional header Magic: 0x10B = PE32, 0x20B = PE32+.
+    magic = struct.unpack_from("<H", data, pe + 24)[0]
+    # DataDirectory starts at +96 (PE32) or +112 (PE32+) of optional header.
+    # Certificate Table is index 4; each entry is 8 bytes (VirtualAddress, Size).
+    dd_start = pe + 24 + (96 if magic == 0x10B else 112)
+    cert_size = struct.unpack_from("<I", data, dd_start + 4 * 8 + 4)[0]
+
+    if cert_size == 0:
+        print(
+            f"ERROR: {path} has no Authenticode signature attached. "
+            "The signing step in crossbuild.mk silently failed.",
+            file=sys.stderr,
+        )
+        return 1
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main(sys.argv))

provider-ci/test-providers/eks/scripts/crossbuild.mk

@@ -59,6 +59,12 @@ bin/%/$(PROVIDER) bin/%/$(PROVIDER).exe: bin/jsign-7.4.jar
 		fi; \
 	fi
 
+	@# Verify the windows binary was actually signed when signing was expected.
+	@# This runs in its own shell as a separate recipe line, so make checks its
+	@# exit code directly (no set-e-inside-if antipattern). Catches the silent
+	@# failure where the signing block above exits 0 without producing a signature.
+	@[ "${GOOS}" != "windows" ] || [ "${SKIP_SIGNING}" = "true" ] || python3 scripts/verify_signed.py "$@"
+
 bin/jsign-7.4.jar:
 	wget https://github.com/ebourg/jsign/releases/download/7.4/jsign-7.4.jar --output-document=bin/jsign-7.4.jar
 

provider-ci/test-providers/eks/scripts/verify_signed.py

@@ -0,0 +1,51 @@
+"""Verify a Windows PE binary has an Authenticode signature attached.
+
+Presence check only: parses the PE Optional Header's Certificate Table
+directory entry and exits 0 if it is non-empty, non-zero otherwise. Does
+not validate the certificate chain or the signature itself; full chain
+validation is the verify-release workflow's job.
+
+Purpose: catch the silent-failure pattern in scripts/crossbuild.mk where
+the signing block exits 0 without producing a signature (e.g. a future
+regression that returns the recipe to /bin/sh and silently skips the
+bash conditional).
+
+Usage: python3 scripts/verify_signed.py <path-to-exe>
+"""
+
+import struct
+import sys
+
+
+def main(argv: list[str]) -> int:
+    if len(argv) != 2:
+        print(
+            f"usage: {argv[0]} <path-to-exe>",
+            file=sys.stderr,
+        )
+        return 2
+    path = argv[1]
+    with open(path, "rb") as f:
+        data = f.read()
+
+    # PE header offset is stored at 0x3C.
+    pe = struct.unpack_from("<I", data, 0x3C)[0]
+    # Optional header Magic: 0x10B = PE32, 0x20B = PE32+.
+    magic = struct.unpack_from("<H", data, pe + 24)[0]
+    # DataDirectory starts at +96 (PE32) or +112 (PE32+) of optional header.
+    # Certificate Table is index 4; each entry is 8 bytes (VirtualAddress, Size).
+    dd_start = pe + 24 + (96 if magic == 0x10B else 112)
+    cert_size = struct.unpack_from("<I", data, dd_start + 4 * 8 + 4)[0]
+
+    if cert_size == 0:
+        print(
+            f"ERROR: {path} has no Authenticode signature attached. "
+            "The signing step in crossbuild.mk silently failed.",
+            file=sys.stderr,
+        )
+        return 1
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main(sys.argv))

provider-ci/test-providers/pulumiservice/scripts/crossbuild.mk

@@ -59,6 +59,12 @@ bin/%/$(PROVIDER) bin/%/$(PROVIDER).exe: bin/jsign-7.4.jar
 		fi; \
 	fi
 
+	@# Verify the windows binary was actually signed when signing was expected.
+	@# This runs in its own shell as a separate recipe line, so make checks its
+	@# exit code directly (no set-e-inside-if antipattern). Catches the silent
+	@# failure where the signing block above exits 0 without producing a signature.
+	@[ "${GOOS}" != "windows" ] || [ "${SKIP_SIGNING}" = "true" ] || python3 scripts/verify_signed.py "$@"
+
 bin/jsign-7.4.jar:
 	wget https://github.com/ebourg/jsign/releases/download/7.4/jsign-7.4.jar --output-document=bin/jsign-7.4.jar
 

provider-ci/test-providers/pulumiservice/scripts/verify_signed.py

@@ -0,0 +1,51 @@
+"""Verify a Windows PE binary has an Authenticode signature attached.
+
+Presence check only: parses the PE Optional Header's Certificate Table
+directory entry and exits 0 if it is non-empty, non-zero otherwise. Does
+not validate the certificate chain or the signature itself; full chain
+validation is the verify-release workflow's job.
+
+Purpose: catch the silent-failure pattern in scripts/crossbuild.mk where
+the signing block exits 0 without producing a signature (e.g. a future
+regression that returns the recipe to /bin/sh and silently skips the
+bash conditional).
+
+Usage: python3 scripts/verify_signed.py <path-to-exe>
+"""
+
+import struct
+import sys
+
+
+def main(argv: list[str]) -> int:
+    if len(argv) != 2:
+        print(
+            f"usage: {argv[0]} <path-to-exe>",
+            file=sys.stderr,
+        )
+        return 2
+    path = argv[1]
+    with open(path, "rb") as f:
+        data = f.read()
+
+    # PE header offset is stored at 0x3C.
+    pe = struct.unpack_from("<I", data, 0x3C)[0]
+    # Optional header Magic: 0x10B = PE32, 0x20B = PE32+.
+    magic = struct.unpack_from("<H", data, pe + 24)[0]
+    # DataDirectory starts at +96 (PE32) or +112 (PE32+) of optional header.
+    # Certificate Table is index 4; each entry is 8 bytes (VirtualAddress, Size).
+    dd_start = pe + 24 + (96 if magic == 0x10B else 112)
+    cert_size = struct.unpack_from("<I", data, dd_start + 4 * 8 + 4)[0]
+
+    if cert_size == 0:
+        print(
+            f"ERROR: {path} has no Authenticode signature attached. "
+            "The signing step in crossbuild.mk silently failed.",
+            file=sys.stderr,
+        )
+        return 1
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main(sys.argv))