fix: use mise bootstrap script so renovate works without pre-installed mise - #2119
Draft
pose wants to merge 2 commits into
Draft
fix: use mise bootstrap script so renovate works without pre-installed mise#2119pose wants to merge 2 commits into
pose wants to merge 2 commits into
Conversation
…d mise Renovate CE runs `make renovate` inside its container, which does not have mise in PATH. This causes `mise_env` and `mise_install` targets to fail, breaking post-upgrade SDK regeneration. Instead of relying on a system-installed mise, commit a self-contained bootstrap script (`bin/mise`, generated by `mise generate bootstrap`) to provider repos. The script downloads and caches the mise binary on first use, requiring no pre-installed tooling. Changes: - Add `bin/mise` bootstrap script to the base Makefile template - Update `mise_env` and `.make/mise_install` to call `./bin/mise` directly - Update `clean` to preserve `bin/mise` (it is a committed file) - Mark `bin/mise` as executable in the generator (alongside `.sh` files) - Add migration to un-ignore `bin/mise` in repos that ignore `bin/` - Update `.gitignore` in provider-ci to allow the template's `bin/mise` Fixes pulumi/home#4462 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: This PR requires testing and thought
Fixes pulumi/home#4462
Summary
make renovateinside its container, which does not havemiseinPATH. Themise_envand.make/mise_installMakefile targets fail immediately, breaking post-upgrade SDK regeneration.bin/misebootstrap script (generated bymise generate bootstrap) to the base template. The script downloads and caches the correct mise binary on first use — no pre-installed tooling required.mise_envand.make/mise_installto call./bin/miseinstead ofmise, so all make targets work in environments without a system mise.cleanto preservebin/misesince it is a committed file, not a build artifact.generate.gologic to markbin/miseas executable when rendering templates.allowBinMise) that adds!bin/miseto.gitignorein repos that ignore thebin/directory, ensuring the bootstrap script can be committed.Test plan
make test-provider/ekspasses with all 11 migrations running/skipping correctlytest-providers/eks/bin/miseis executable (-rwxr-xr-x)test-providers/eks/Makefileuses./bin/miseinmise_envand.make/mise_installtest-providers/eks/Makefileusesfind bin -mindepth 1 ! -name mise -deleteincleanmake renovatecompletes successfully after onboarding🤖 Generated with Claude Code