Allow bridged providers to opt into test sharding - #1293
Merged
Conversation
t0yv0
marked this pull request as ready for review
January 15, 2025 22:31
t0yv0
changed the title
rquitales
reviewed
Jan 16, 2025
| uses: ./.github/actions/setup-tools | ||
| #{{- if not .Config.Shards }}# | ||
| with: | ||
| tools: pulumictl, pulumicli, ${{ matrix.language }} |
Contributor
There was a problem hiding this comment.
Do we not need pulumi and pulumictl when we shard as well?
Contributor
There was a problem hiding this comment.
Nevermind. The default is to install all tools if not specified.
rquitales
approved these changes
Jan 16, 2025
t0yv0
force-pushed
the
t0yv0/bridged-test-sharding
branch
from
January 16, 2025 21:07
ad333b0 to
7d68154
Compare
t0yv0
enabled auto-merge
January 16, 2025 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rebases @blampe work on sharding for bridged providers #1217 with minor simplifications. An example PR applying this work is found here: pulumi/pulumi-awsx#1487
There should be no visible change for providers unless they opt in with "shards: 3" or similar. For providers that do opt in, the test job will stop splitting the build matrix by language and instead create a build matrix with as many workers as shards requested, and randomly assign integration tests to these workers. This permits better loading as typically language-based strategies end up being heavy on Node tests. It also permits having more workers than languages.
This work is prerequisite to onboarding pulumi-eks to ci-mgmt via the simplified bridge template.