script: keep untyped files in flist output#316
Open
micprog wants to merge 1 commit into
Open
Conversation
Regression from v0.30.0 (d0c1e13): switching the flist/flist-plus templates from `all_files` to the per-type split source groups silently dropped files whose extension isn't a recognized HDL type (.c, .tcl, .txt, ...), because untyped files were never emitted into those groups. Emit untyped files as their own groups (file_type = None) so they reappear in flist/flist-plus. Tool-script formats that branch on file type (vsim, vcs, synopsys, formality, riviera, genus, precision) previously fell through their `file_type != ''` guard and emitted broken compile commands for such files; they now comment them out instead. Type-agnostic (vivado) and Verilog-only (verilator) formats are unaffected. Add a regression fixture with a non-HDL file plus tests covering flist inclusion and tool-script commenting. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from v0.30.0 (d0c1e13): switching the flist/flist-plus templates from
all_filesto the per-type split source groups silently dropped files whose extension isn't a recognized HDL type (.c, .tcl, .txt, ...), because untyped files were never emitted into those groups.Emit untyped files as their own groups (file_type = None) so they reappear in flist/flist-plus. Tool-script formats that branch on file type (vsim, vcs, synopsys, formality, riviera, genus, precision) previously fell through their
file_type != ''guard and emitted broken compile commands for such files; they now comment them out instead. Type-agnostic (vivado) and Verilog-only (verilator) formats are unaffected.Add a regression fixture with a non-HDL file plus tests covering flist inclusion and tool-script commenting.