fix: Sanitize HTML output in PropertiesOverview component to prevent invalid HTML - #352
Merged
Conversation
deleonio
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the way type information is rendered in the
PropertiesOverviewcomponent to prevent invalid HTML and potential security issues. The main change is that type strings are now properly escaped before being inserted into the DOM.Rendering and security improvements:
src/components/PropertiesOverview.tsx: Escaped special HTML characters in thetypesarray before joining and rendering, preventing invalid HTML and reducing XSS risk.The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer: