Fix toolbar example - #344
Merged
deleonio merged 1 commit intoJul 14, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the toolbar example by correcting the JSON quoting of the _items prop in both the fenced code block and the inline usage snippet.
- Updated
_itemsattribute to use single quotes around the JSON string and double quotes inside. - Applied the same correction to the main example and the usage section.
Comments suppressed due to low confidence (2)
docs/30-components/toolbar.mdx:22
- [nitpick] Since the toolbar has no child elements here, consider using a self-closing tag for brevity and to avoid unnecessary whitespace, e.g.,
<kol-toolbar ... />.
<kol-toolbar _label="Label" _items='[{"_label": "Button"}, {"_href": "#", "_label": "Link"}]'> </kol-toolbar>
docs/30-components/toolbar.mdx:29
- [nitpick] You can simplify this snippet by converting it to a self-closing tag (e.g.,
/>) since there are no nested children in the example.
_items='[{"_label": "Button"}, {"_href": "#", "_label": "Link"}]'>
Contributor
deleonio
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer: