fix(components): use aria-describedby for button and link descriptions - #10677
Open
deleonio wants to merge 1 commit into
Open
fix(components): use aria-describedby for button and link descriptions#10677deleonio wants to merge 1 commit into
deleonio wants to merge 1 commit into
Conversation
Replaces the bare aria-description attribute (ARIA 1.2, poor screen reader support) with the robust aria-describedby + visually-hidden span pattern. This restores the behavior from before f5957ac and makes button/link consistent with all form controls, so the accessible description is reliably announced after the accessible name. fixes #10615
deleonio
added
the
release:fix
Contributor
|
🚀 MCP preview deployed to Vercel: https://kolibri-c674iygjc-public-ui-kolibri-mcp.vercel.app |
Contributor
|
Netlify Draft Deployment |
Contributor
|
🚀 Preview deployed to GitHub Pages: https://public-ui.github.io/kolibri/pr-10677/51b366e/ |
Contributor
📸 Visual Test Reports
Run: https://github.com/public-ui/kolibri/actions/runs/31680690251 |
laske185
approved these changes
Aug 14, 2026
Contributor
|
@deleonio Schau dir mal die Unit Tests an. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10615
The
ariaDescriptiononkol-button/kol-linkwas rendered as the barearia-descriptionattribute (ARIA 1.2). This attribute has poor/inconsistent screen reader support (NVDA, JAWS, VoiceOver often ignore it or announce it in the wrong order), so the accessible description was read before the label instead of after it.Commit
f5957ac8aehad replaced the previously robustaria-describedby+ visually-hidden span pattern with the barearia-descriptionattribute. This PR reverts button and link to the robust pattern and thereby makes them consistent with all form controls (input-text,select,textarea, …), which already usearia-describedby.Changes
button/component.tsx:aria-description→aria-describedby(IDREF) + visually-hidden<span>link/component.tsx: same changeDetailed analysis is posted in #10615.
Checklist
pnpm formatapplied